[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps() |
|
Date: |
Thu, 24 Oct 2019 10:20:07 -0300 |
On Thu, Oct 24, 2019 at 10:54:57AM +0100, Daniel P. Berrangé wrote:
> On Sun, Oct 20, 2019 at 07:11:14PM +0800, Tao Xu wrote:
> > To convert strings with time suffixes to numbers, support time unit are
> > "ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms"
> > for millisecond or "s" for second.
> >
> > Signed-off-by: Tao Xu <address@hidden>
> > ---
> >
> > No changes in v13.
> > ---
> > include/qemu/cutils.h | 1 +
> > util/cutils.c | 82 +++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 83 insertions(+)
>
> This really ought to have an addition to the unit tests to validating
> the parsing, both success and error scenarios, so that we're clear on
> exactly what strings are accepted & rejected.
Unit tests are in patch 02/12. It's a good idea to squash
patches 01 and 02 together.
--
Eduardo
- Re: [PATCH v13 06/12] numa: Extend CLI to provide memory latency and bandwidth information, (continued)
- [PATCH v13 05/12] numa: Extend CLI to provide initiator information for numa nodes, Tao Xu, 2019/10/20
- [PATCH v13 07/12] numa: Calculate hmat latency and bandwidth entry list, Tao Xu, 2019/10/20
- [PATCH v13 10/12] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s), Tao Xu, 2019/10/20
- [PATCH v13 09/12] hmat acpi: Build Memory Proximity Domain Attributes Structure(s), Tao Xu, 2019/10/20
- [PATCH v13 11/12] hmat acpi: Build Memory Side Cache Information Structure(s), Tao Xu, 2019/10/20
- [PATCH v13 12/12] tests/bios-tables-test: add test cases for ACPI HMAT, Tao Xu, 2019/10/20
- Re: [PATCH v13 00/12] Build ACPI Heterogeneous Memory Attribute Table (HMAT), no-reply, 2019/10/20