qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/30] virtiofs daemon (base)


From: Michael S. Tsirkin
Subject: Re: [PATCH 00/30] virtiofs daemon (base)
Date: Thu, 24 Oct 2019 06:59:33 -0400

On Mon, Oct 21, 2019 at 03:33:57PM +0100, Dr. David Alan Gilbert wrote:
> * address@hidden (address@hidden) wrote:
> > Patchew URL: https://patchew.org/QEMU/address@hidden/
> > 
> > 
> > 
> > Hi,
> > 
> > This series seems to have some coding style problems. See output below for
> > more information:
> > 
> > Subject: [PATCH 00/30] virtiofs daemon (base)
> > Type: series
> > Message-id: address@hidden
> > 
> > === TEST SCRIPT BEGIN ===
> > #!/bin/bash
> > git rev-parse base > /dev/null || exit 0
> > git config --local diff.renamelimit 0
> > git config --local diff.renames True
> > git config --local diff.algorithm histogram
> > ./scripts/checkpatch.pl --mailback base..
> 
> Expecting checkpatch to be broken here; most of the files
> follow FUSE's formatting.
> 
> Dave

I wonder what do others think about this.
One problem with such inconsistencies is that people tend to copy code
around, which tends to result in a mess.

> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK



reply via email to

[Prev in Thread] Current Thread [Next in Thread]