[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/30] virtiofs daemon (base)
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH 00/30] virtiofs daemon (base) |
Date: |
Thu, 24 Oct 2019 06:59:33 -0400 |
On Mon, Oct 21, 2019 at 03:33:57PM +0100, Dr. David Alan Gilbert wrote:
> * address@hidden (address@hidden) wrote:
> > Patchew URL: https://patchew.org/QEMU/address@hidden/
> >
> >
> >
> > Hi,
> >
> > This series seems to have some coding style problems. See output below for
> > more information:
> >
> > Subject: [PATCH 00/30] virtiofs daemon (base)
> > Type: series
> > Message-id: address@hidden
> >
> > === TEST SCRIPT BEGIN ===
> > #!/bin/bash
> > git rev-parse base > /dev/null || exit 0
> > git config --local diff.renamelimit 0
> > git config --local diff.renames True
> > git config --local diff.algorithm histogram
> > ./scripts/checkpatch.pl --mailback base..
>
> Expecting checkpatch to be broken here; most of the files
> follow FUSE's formatting.
>
> Dave
I wonder what do others think about this.
One problem with such inconsistencies is that people tend to copy code
around, which tends to result in a mess.
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [PATCH 21/30] virtiofsd: Start reading commands from queue, (continued)
- [PATCH 27/30] virtiofsd: make -f (foreground) the default, Dr. David Alan Gilbert (git), 2019/10/21
- [PATCH 24/30] virtiofsd: Add Makefile wiring for virtiofsd contrib, Dr. David Alan Gilbert (git), 2019/10/21
- [PATCH 26/30] virtiofsd: add --fd=FDNUM fd passing option, Dr. David Alan Gilbert (git), 2019/10/21
- [PATCH 25/30] virtiofsd: Fast path for virtio read, Dr. David Alan Gilbert (git), 2019/10/21
- [PATCH 29/30] virtiofsd: add --print-capabilities option, Dr. David Alan Gilbert (git), 2019/10/21
- [PATCH 30/30] virtiofs: Add maintainers entry, Dr. David Alan Gilbert (git), 2019/10/21
- [PATCH 28/30] virtiofsd: add vhost-user.json file, Dr. David Alan Gilbert (git), 2019/10/21
- Re: [PATCH 00/30] virtiofs daemon (base), no-reply, 2019/10/21
- Re: [PATCH 00/30] virtiofs daemon (base), Dr. David Alan Gilbert, 2019/10/21
- Re: [PATCH 00/30] virtiofs daemon (base),
Michael S. Tsirkin <=
- Re: [PATCH 00/30] virtiofs daemon (base), Dr. David Alan Gilbert, 2019/10/24
- Re: [PATCH 00/30] virtiofs daemon (base), Daniel P . Berrangé, 2019/10/24
- Re: [PATCH 00/30] virtiofs daemon (base), Dr. David Alan Gilbert, 2019/10/24
- Re: [PATCH 00/30] virtiofs daemon (base), Michael S. Tsirkin, 2019/10/24
- Re: [PATCH 00/30] virtiofs daemon (base), Dr. David Alan Gilbert, 2019/10/24
- Re: [PATCH 00/30] virtiofs daemon (base), Daniel P . Berrangé, 2019/10/24
- Re: [PATCH 00/30] virtiofs daemon (base), Dr. David Alan Gilbert, 2019/10/24
Re: [PATCH 00/30] virtiofs daemon (base), Michael S. Tsirkin, 2019/10/24
Re: [PATCH 00/30] virtiofs daemon (base), Michael S. Tsirkin, 2019/10/27