[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/12] translate-all: Remove tb_alloc
From: |
Richard Henderson |
Subject: |
[PULL 12/12] translate-all: Remove tb_alloc |
Date: |
Fri, 25 Oct 2019 10:21:59 -0400 |
Since 2ac01d6dafab, this function does only two things: assert a
lock is held, and call tcg_tb_alloc. It is used exactly once,
and its user has already done the assert.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Clement Deschamps <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
accel/tcg/translate-all.c | 20 ++------------------
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index f9b7ba159d..ae063b53f9 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -1156,23 +1156,6 @@ void tcg_exec_init(unsigned long tb_size)
#endif
}
-/*
- * Allocate a new translation block. Flush the translation buffer if
- * too many translation blocks or too much generated code.
- */
-static TranslationBlock *tb_alloc(target_ulong pc)
-{
- TranslationBlock *tb;
-
- assert_memory_lock();
-
- tb = tcg_tb_alloc(tcg_ctx);
- if (unlikely(tb == NULL)) {
- return NULL;
- }
- return tb;
-}
-
/* call with @p->lock held */
static inline void invalidate_page_bitmap(PageDesc *p)
{
@@ -1681,6 +1664,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu,
TCGProfile *prof = &tcg_ctx->prof;
int64_t ti;
#endif
+
assert_memory_lock();
phys_pc = get_page_addr_code(env, pc);
@@ -1706,7 +1690,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu,
}
buffer_overflow:
- tb = tb_alloc(pc);
+ tb = tcg_tb_alloc(tcg_ctx);
if (unlikely(!tb)) {
/* flush must be done */
tb_flush(cpu);
--
2.17.1
- [PULL 03/12] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN, (continued)
- [PULL 03/12] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN, Richard Henderson, 2019/10/25
- [PULL 02/12] cputlb: ensure _cmmu helper functions follow the naming standard, Richard Henderson, 2019/10/25
- [PULL 04/12] exec: Split out variable page size support to exec-vary.c, Richard Henderson, 2019/10/25
- [PULL 05/12] configure: Detect compiler support for __attribute__((alias)), Richard Henderson, 2019/10/25
- [PULL 06/12] exec: Use const alias for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/10/25
- [PULL 07/12] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG, Richard Henderson, 2019/10/25
- [PULL 08/12] exec: Promote TARGET_PAGE_MASK to target_long, Richard Henderson, 2019/10/25
- [PULL 10/12] cputlb: Fix tlb_vaddr_to_host, Richard Henderson, 2019/10/25
- [PULL 09/12] exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/10/25
- [PULL 11/12] translate-all: fix uninitialized tb->orig_tb, Richard Henderson, 2019/10/25
- [PULL 12/12] translate-all: Remove tb_alloc,
Richard Henderson <=
- Re: [PULL 00/12] tcg patch queue, Peter Maydell, 2019/10/25
- Re: [PULL 00/12] tcg patch queue, no-reply, 2019/10/26