Re: [PULL 00/12] tcg patch queue

[Peter Maydell]

On Fri, 25 Oct 2019 at 15:22, Richard Henderson
<address@hidden> wrote:
>
> The following changes since commit bad76ac319556dab2497429d473b49a237672e1c:
>
>   Merge remote-tracking branch 
> 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-10-25 
> 14:17:08 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/rth7680/qemu.git tags/pull-tcg-20191025
>
> for you to fetch changes up to 0ed1bfb046b740b70eed2cf3581e01768703b185:
>
>   translate-all: Remove tb_alloc (2019-10-25 10:15:25 -0400)
>
> ----------------------------------------------------------------
> Improvements for TARGET_PAGE_BITS_VARY
> Fix for TCI ld16u_i64.
> Fix for segv on icount execute from i/o memory.
> Two misc cleanups.
>
> ----------------------------------------------------------------

Compile failure, win32:

In file included from
/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/lib/glib-2.0/include/glibconfig.h:9:0,
                 from
/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0/glib/gtypes.h:32,
                 from
/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0/glib/galloca.h:32,
                 from
/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0/glib.h:30,
                 from /home/petmay01/qemu-for-merges/include/glib-compat.h:32,
                 from /home/petmay01/qemu-for-merges/include/qemu/osdep.h:140,
                 from /home/petmay01/qemu-for-merges/exec.c:20:
/home/petmay01/qemu-for-merges/include/exec/cpu-all.h: In function
'tlb_hit_page':
/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0/glib/gmacros.h:337:23:
error: expected expression befor
e 'do'
 #define G_STMT_START  do
                       ^
/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0/glib/gtestutils.h:115:41:
note: in expansion of macro 'G_STMT_START'
 #define g_assert(expr)                  G_STMT_START { \
                                         ^
/home/petmay01/qemu-for-merges/include/qemu/osdep.h:152:20: note: in
expansion of macro 'g_assert'
 #define assert(x)  g_assert(x)
                    ^
/home/petmay01/qemu-for-merges/include/exec/cpu-all.h:225:29: note: in
expansion of macro 'assert'
 #  define TARGET_PAGE_MASK (assert(target_page.decided), target_page.mask)
                             ^
/home/petmay01/qemu-for-merges/include/exec/cpu-all.h:372:33: note: in
expansion of macro 'TARGET_PAGE_MASK'
     return addr == (tlb_addr & (TARGET_PAGE_MASK | TLB_INVALID_MASK));
                                 ^

(repeated in all the other places TARGET_PAGE_MASK is used;
similar for TARGET_PAGE_BITS.)

Also
/home/petmay01/qemu-for-merges/exec.c: In function 'iotlb_to_section':
/home/petmay01/qemu-for-merges/exec.c:2871:1: error: control reaches
end of non-void function [-Werror=return-type]
 }
 ^
/home/petmay01/qemu-for-merges/exec.c: In function 'qemu_target_page_size':
/home/petmay01/qemu-for-merges/exec.c:3791:1: error: control reaches
end of non-void function [-Werror=return-type]
 }
 ^
/home/petmay01/qemu-for-merges/exec.c: In function 'qemu_target_page_bits':
/home/petmay01/qemu-for-merges/exec.c:3796:1: error: control reaches
end of non-void function [-Werror=return-type]
 }
 ^
cc1: all warnings being treated as errors
/home/petmay01/qemu-for-merges/exec.c: In function 'last_ram_page':
/home/petmay01/qemu-for-merges/exec.c:1977:1: error: control reaches
end of non-void function [-Werror=return-type]
 }
 ^
/home/petmay01/qemu-for-merges/exec.c: In function 'iotlb_to_section':
/home/petmay01/qemu-for-merges/exec.c:2871:1: error: control reaches
end of non-void function [-Werror=return-type]
 }
 ^

Not sure if that's just follow-on errors from the earlier
ones, though.

thanks
-- PMM