Re: [PATCH 03/26] tests/acceptance: Fixe wait_for_console_pattern() hangs

[Aleksandar Markovic]

On Monday, October 28, 2019, Philippe Mathieu-Daudé <address@hidden> wrote:
> Because of a possible deadlock (QEMU waiting for the socket to
> become writable) let's close the console socket as soon as we
> stop to use it.
>
> Suggested-by: Cleber Rosa <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  tests/acceptance/avocado_qemu/__init__.py | 1 +
>  1 file changed, 1 insertion(+)

Fixe -> Fix

You missed my r-b again, given in:

https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg06376.html

A.

 

> diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
> index e3101cba30..a0450e5263 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py
> @@ -74,6 +74,7 @@ def wait_for_console_pattern(test, success_message, failure_message=None):
>          if success_message in msg:
>              break
>          if failure_message and failure_message in msg:
> +            console.close()
>              fail = 'Failure message found in console: %s' % failure_message
>              test.fail(fail)
>  
> -- 
> 2.21.0