Re: [PATCH 04/26] tests/acceptance: Send <carriage return> on serial lines

[Cleber Rosa]

On Mon, Oct 28, 2019 at 08:34:19AM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé <address@hidden>
> 
> Some firmwares don't parse the <Newline> control character and
> expect a <carriage return>.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> since previous: do not send NewLine
> ---
>  tests/acceptance/boot_linux_console.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/acceptance/boot_linux_console.py 
> b/tests/acceptance/boot_linux_console.py
> index 8897e0c253..f9b77af359 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -34,7 +34,7 @@ class BootLinuxConsole(Test):
>                                   failure_message='Kernel panic - not 
> syncing')
>  
>      def exec_command_and_wait_for_pattern(self, command, success_message):
> -        command += '\n'
> +        command += '\r'
>          self.vm.console_socket.sendall(command.encode())
>          wait_for_console_pattern(self, success_message)
>  
> -- 
> 2.21.0
> 

Given the discussion on
<address@hidden>, this LGTM.

Reviewed-by: Cleber Rosa <address@hidden>
Tested-by: Cleber Rosa <address@hidden>

Queuing on my python-next branch (and sending shortly in a PR).

Thanks,
- Cleber.