[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 04/12] linux-user/sparc: Use WREG constants in sparc/target_cp
From: |
Richard Henderson |
Subject: |
[PATCH v3 04/12] linux-user/sparc: Use WREG constants in sparc/target_cpu.h |
Date: |
Wed, 6 Nov 2019 12:33:10 +0100 |
This fixes a naming bug wherein we used "UREG_FP" to access the
stack pointer. OTOH, the "UREG_FP" constant was also defined
incorrectly such that it *did* reference the stack pointer.
Note that the kernel legitimately uses the name "FP", because it
utilizes the rolled stack window in processing the system call.
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
linux-user/sparc/target_cpu.h | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/linux-user/sparc/target_cpu.h b/linux-user/sparc/target_cpu.h
index 1ffc0ae9f2..b30fbc72c4 100644
--- a/linux-user/sparc/target_cpu.h
+++ b/linux-user/sparc/target_cpu.h
@@ -41,15 +41,9 @@ static inline void cpu_set_tls(CPUSPARCState *env,
target_ulong newtls)
env->gregs[7] = newtls;
}
-#ifndef UREG_I6
-#define UREG_I6 6
-#endif
-#ifndef UREG_FP
-#define UREG_FP UREG_I6
-#endif
-
static inline abi_ulong get_sp_from_cpustate(CPUSPARCState *state)
{
- return state->regwptr[UREG_FP];
+ return state->regwptr[WREG_SP];
}
+
#endif
--
2.17.1
- [PATCH v3 00/12] linux-user sparc fixes, Richard Henderson, 2019/11/06
- [PATCH v3 02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat, Richard Henderson, 2019/11/06
- [PATCH v3 01/12] scripts/qemu-binfmt-conf: Update for sparc64, Richard Henderson, 2019/11/06
- [PATCH v3 03/12] target/sparc: Define an enumeration for accessing env->regwptr, Richard Henderson, 2019/11/06
- [PATCH v3 04/12] linux-user/sparc: Use WREG constants in sparc/target_cpu.h,
Richard Henderson <=
- [PATCH v3 06/12] linux-user/sparc: Use WREG_SP constant in sparc/signal.c, Richard Henderson, 2019/11/06
- [PATCH v3 05/12] linux-user/sparc: Begin using WREG constants in sparc/signal.c, Richard Henderson, 2019/11/06
- [PATCH v3 07/12] linux-user/sparc: Fix WREG usage in setup_frame, Richard Henderson, 2019/11/06
- [PATCH v3 08/12] linux-user/sparc64: Fix target_signal_frame, Richard Henderson, 2019/11/06
- [PATCH v3 09/12] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child, Richard Henderson, 2019/11/06
- [PATCH v3 10/12] linux-user: Introduce cpu_clone_regs_parent, Richard Henderson, 2019/11/06
- [PATCH v3 11/12] linux-user/sparc: Fix cpu_clone_regs_*, Richard Henderson, 2019/11/06
- [PATCH v3 12/12] linux-user/alpha: Set r20 secondary return value, Richard Henderson, 2019/11/06
- Re: [PATCH v3 00/12] linux-user sparc fixes, Laurent Vivier, 2019/11/06
- Re: [PATCH v3 00/12] linux-user sparc fixes, no-reply, 2019/11/06