[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 06/12] linux-user/sparc: Use WREG_SP constant in sparc/signal.
From: |
Richard Henderson |
Subject: |
[PATCH v3 06/12] linux-user/sparc: Use WREG_SP constant in sparc/signal.c |
Date: |
Wed, 6 Nov 2019 12:33:12 +0100 |
s/UREG_FP/WREG_SP/g
This is non-obvious because the UREG_FP constant is fact wrong.
However, the previous search-and-replace patch made it clear that
UREG_FP expands to WREG_O6, and we can see from the enumeration in
target/sparc/cpu.h that WREG_O6 is in fact WREG_SP, the stack pointer.
The UREG_SP define is unused; remove it.
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
linux-user/sparc/signal.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c
index aac37da239..e05693f204 100644
--- a/linux-user/sparc/signal.c
+++ b/linux-user/sparc/signal.c
@@ -104,9 +104,6 @@ struct target_rt_signal_frame {
qemu_siginfo_fpu_t fpu_state;
};
-#define UREG_FP WREG_O6
-#define UREG_SP WREG_I6
-
static inline abi_ulong get_sigframe(struct target_sigaction *sa,
CPUSPARCState *env,
unsigned long framesize)
@@ -201,7 +198,7 @@ void setup_frame(int sig, struct target_sigaction *ka,
goto sigsegv;
/* 3. signal handler back-trampoline and parameters */
- env->regwptr[UREG_FP] = sf_addr;
+ env->regwptr[WREG_SP] = sf_addr;
env->regwptr[WREG_O0] = sig;
env->regwptr[WREG_O1] = sf_addr +
offsetof(struct target_signal_frame, info);
@@ -255,7 +252,7 @@ long do_sigreturn(CPUSPARCState *env)
sigset_t host_set;
int i;
- sf_addr = env->regwptr[UREG_FP];
+ sf_addr = env->regwptr[WREG_SP];
trace_user_do_sigreturn(env, sf_addr);
if (!lock_user_struct(VERIFY_READ, sf, sf_addr, 1)) {
goto segv_and_exit;
--
2.17.1
- [PATCH v3 00/12] linux-user sparc fixes, Richard Henderson, 2019/11/06
- [PATCH v3 02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat, Richard Henderson, 2019/11/06
- [PATCH v3 01/12] scripts/qemu-binfmt-conf: Update for sparc64, Richard Henderson, 2019/11/06
- [PATCH v3 03/12] target/sparc: Define an enumeration for accessing env->regwptr, Richard Henderson, 2019/11/06
- [PATCH v3 04/12] linux-user/sparc: Use WREG constants in sparc/target_cpu.h, Richard Henderson, 2019/11/06
- [PATCH v3 06/12] linux-user/sparc: Use WREG_SP constant in sparc/signal.c,
Richard Henderson <=
- [PATCH v3 05/12] linux-user/sparc: Begin using WREG constants in sparc/signal.c, Richard Henderson, 2019/11/06
- [PATCH v3 07/12] linux-user/sparc: Fix WREG usage in setup_frame, Richard Henderson, 2019/11/06
- [PATCH v3 08/12] linux-user/sparc64: Fix target_signal_frame, Richard Henderson, 2019/11/06
- [PATCH v3 09/12] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child, Richard Henderson, 2019/11/06
- [PATCH v3 10/12] linux-user: Introduce cpu_clone_regs_parent, Richard Henderson, 2019/11/06
- [PATCH v3 11/12] linux-user/sparc: Fix cpu_clone_regs_*, Richard Henderson, 2019/11/06
- [PATCH v3 12/12] linux-user/alpha: Set r20 secondary return value, Richard Henderson, 2019/11/06
- Re: [PATCH v3 00/12] linux-user sparc fixes, Laurent Vivier, 2019/11/06
- Re: [PATCH v3 00/12] linux-user sparc fixes, no-reply, 2019/11/06