[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 26/26] qdev: use object_property_help()
From: |
Marc-André Lureau |
Subject: |
[PATCH 26/26] qdev: use object_property_help() |
Date: |
Sun, 1 Dec 2019 15:15:31 +0400 |
Use the common function introduced earlier, and report default value.
Signed-off-by: Marc-André Lureau <address@hidden>
---
qdev-monitor.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index e6b112eb0a..5a09031e53 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -286,16 +286,11 @@ int qdev_device_help(QemuOpts *opts)
qemu_printf("There are no options for %s.\n", driver);
}
for (prop = prop_list; prop; prop = prop->next) {
- int len;
- qemu_printf(" %s=<%s>%n", prop->value->name, prop->value->type, &len);
- if (prop->value->has_description) {
- if (len < 24) {
- qemu_printf("%*s", 24 - len, "");
- }
- qemu_printf(" - %s\n", prop->value->description);
- } else {
- qemu_printf("\n");
- }
+ g_autofree char *help = object_property_help(prop->value->name,
+ prop->value->type,
+
prop->value->default_value,
+ prop->value->description);
+ qemu_printf("%s\n", help);
}
qapi_free_ObjectPropertyInfoList(prop_list);
--
2.24.0
- [PATCH 18/26] object: return self in object_ref(), (continued)
- [PATCH 18/26] object: return self in object_ref(), Marc-André Lureau, 2019/12/01
- [PATCH 20/26] qdev: move instance properties to class properties, Marc-André Lureau, 2019/12/01
- [PATCH 21/26] qdev: register properties as class properties, Marc-André Lureau, 2019/12/01
- [PATCH 19/26] qdev: set properties with device_class_set_props(), Marc-André Lureau, 2019/12/01
- [PATCH 22/26] vl: print default value in object help, Marc-André Lureau, 2019/12/01
- [PATCH 23/26] qom: simplify qmp_device_list_properties(), Marc-André Lureau, 2019/12/01
- [PATCH 24/26] qom: introduce object_property_help(), Marc-André Lureau, 2019/12/01
- [PATCH 25/26] qapi/qmp: add ObjectPropertyInfo.default-value, Marc-André Lureau, 2019/12/01
- [PATCH 26/26] qdev: use object_property_help(),
Marc-André Lureau <=