Re: [PATCH 25/26] qapi/qmp: add ObjectPropertyInfo.default-value

[Eric Blake]

On 12/1/19 5:15 AM, Marc-André Lureau wrote:
> Report the default value associated with a property.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>   qapi/qom.json      | 7 ++++++-
>   qom/qom-qmp-cmds.c | 4 ++++
>   2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/qom.json b/qapi/qom.json
> index 32db96ffc4..471e4b484b 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -26,10 +26,15 @@
>   #
>   # @description: if specified, the description of the property.
>   #
> +# @default-value: the default value, if any (since 5.0)
> +#
>   # Since: 1.2
>   ##
>   { 'struct': 'ObjectPropertyInfo',
> -  'data': { 'name': 'str', 'type': 'str', '*description': 'str' } }
> +  'data': { 'name': 'str',
> +            'type': 'str',
> +            '*description': 'str',
> +            '*default-value': 'str' } }

Do we always want to output the stringized value, or would it be wise to 
make this 'any' and output integers where that makes sense?


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org