Re: [PATCH v3 2/3] spapr: Add NVDIMM device support

[Shivaprasad G Bhat]

Hi David,

On 11/22/2019 10:00 AM, David Gibson wrote:
> On Mon, Oct 14, 2019 at 01:37:50PM -0500, Shivaprasad G Bhat wrote:
> ---
> > index 62f1a42592..815167e42f 100644
> > --- a/hw/ppc/spapr_drc.c
> > +++ b/hw/ppc/spapr_drc.c
> > @@ -708,6 +708,17 @@ static void spapr_drc_phb_class_init(ObjectClass *k, void 
> > *data)
> >       drck->dt_populate = spapr_phb_dt_populate;
> >   }
> >   
> > +static void spapr_drc_pmem_class_init(ObjectClass *k, void *data)
> > +{
> > +    SpaprDrcClass *drck = SPAPR_DR_CONNECTOR_CLASS(k);
> > +
> > +    drck->typeshift = SPAPR_DR_CONNECTOR_TYPE_SHIFT_PMEM;
> > +    drck->typename = "MEM";
> This is the same as the typename for LMB DRCs.  Doesn't that mean that
> ibm,drc-types will end up with a duplicate in it?

Correct, this has to be "PMEM" instead of "MEM". Fixing it in next version.

Thanks,
Shivaprasad

> > +    drck->drc_name_prefix = "PMEM ";