[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/6] hw/display/tcx: Add missing fall through comments
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 2/6] hw/display/tcx: Add missing fall through comments |
Date: |
Wed, 18 Dec 2019 20:25:22 +0100 |
When building with GCC9 using CFLAG -Wimplicit-fallthrough=2 we get:
hw/display/tcx.c: In function ‘tcx_dac_writel’:
hw/display/tcx.c:453:26: error: this statement may fall through
[-Werror=implicit-fallthrough=]
453 | s->dac_index = (s->dac_index + 1) & 0xff; /* Index
autoincrement */
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/display/tcx.c:454:9: note: here
454 | default:
| ^~~~~~~
hw/display/tcx.c: In function ‘tcx_dac_readl’:
hw/display/tcx.c:412:22: error: this statement may fall through
[-Werror=implicit-fallthrough=]
412 | s->dac_index = (s->dac_index + 1) & 0xff; /* Index
autoincrement */
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/display/tcx.c:413:5: note: here
413 | default:
| ^~~~~~~
cc1: all warnings being treated as errors
Give a hint to GCC by adding the missing fall through comments.
Fixes: 55d7bfe22
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
v2: Reword the description (Aleksandar)
Cc: Aleksandar Markovic <address@hidden>
Cc: Olivier Danet <address@hidden>
Cc: Mark Cave-Ayland <address@hidden>
---
hw/display/tcx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/display/tcx.c b/hw/display/tcx.c
index 14e829d3fa..abbeb30284 100644
--- a/hw/display/tcx.c
+++ b/hw/display/tcx.c
@@ -410,6 +410,7 @@ static uint64_t tcx_dac_readl(void *opaque, hwaddr addr,
case 2:
val = s->b[s->dac_index] << 24;
s->dac_index = (s->dac_index + 1) & 0xff; /* Index autoincrement */
+ /* fall through */
default:
s->dac_state = 0;
break;
@@ -451,6 +452,7 @@ static void tcx_dac_writel(void *opaque, hwaddr addr,
uint64_t val,
s->b[index] = val >> 24;
update_palette_entries(s, index, index + 1);
s->dac_index = (s->dac_index + 1) & 0xff; /* Index autoincrement */
+ /* fall through */
default:
s->dac_state = 0;
break;
--
2.21.0
- [PATCH v2 0/6] Fix more GCC9 -O3 warnings, Philippe Mathieu-Daudé, 2019/12/18
- [PATCH v2 1/6] audio/audio: Add missing fall through comment, Philippe Mathieu-Daudé, 2019/12/18
- [PATCH v2 2/6] hw/display/tcx: Add missing fall through comments,
Philippe Mathieu-Daudé <=
- [PATCH v2 4/6] hw/net/imx_fec: Rewrite fall through comments, Philippe Mathieu-Daudé, 2019/12/18
- [PATCH v2 3/6] hw/timer/aspeed_timer: Add a fall through comment, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 5/6] hw/net/imx_fec: Remove unuseful FALLTHROUGH comments, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 6/6] hw/pci-host/designware: Remove unuseful FALLTHROUGH comment, Philippe Mathieu-Daudé, 2019/12/18