Re: [PATCH v2 1/6] audio/audio: Add missing fall through comment

[Aleksandar Markovic]

On Wed, Dec 18, 2019 at 8:26 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> When building with GCC9 using CFLAG -Wimplicit-fallthrough=2 we get:
>
>   audio/audio.c: In function ‘audio_pcm_init_info’:
>   audio/audio.c:306:14: error: this statement may fall through 
> [-Werror=implicit-fallthrough=]
>     306 |         sign = 1;
>         |         ~~~~~^~~
>   audio/audio.c:307:5: note: here
>     307 |     case AUDIO_FORMAT_U8:
>         |     ^~~~
>   cc1: all warnings being treated as errors
>
> Similarly to e46349414, add the missing fall through comment to
> hint GCC.
>
> Fixes: 2b9cce8c8c
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> v2: Reword the description (Aleksandar)
>

Reviewed-by: Aleksandar Markovic <address@hidden>

> Cc: Aleksandar Markovic <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: "Kővágó, Zoltán" <address@hidden>
> ---
>  audio/audio.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/audio/audio.c b/audio/audio.c
> index 56fae55047..57daf3f620 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -304,6 +304,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info, 
> struct audsettings *as)
>      switch (as->fmt) {
>      case AUDIO_FORMAT_S8:
>          sign = 1;
> +        /* fall through */
>      case AUDIO_FORMAT_U8:
>          mul = 1;
>          break;
> --
> 2.21.0
>