Re: [PATCH v6 7/8] dockerfiles: add dbus-daemon to some of latest distributions

[Marc-André Lureau]

Hi

On Thu, Dec 12, 2019 at 4:07 PM Daniel P. Berrangé <address@hidden> wrote:
>
> On Wed, Dec 11, 2019 at 05:45:05PM +0400, Marc-André Lureau wrote:
> > To get dbus-vmstate test covered.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > ---
> >  tests/docker/dockerfiles/centos7.docker  | 1 +
> >  tests/docker/dockerfiles/debian10.docker | 1 +
> >  tests/docker/dockerfiles/fedora.docker   | 1 +
> >  tests/docker/dockerfiles/ubuntu.docker   | 1 +
> >  4 files changed, 4 insertions(+)
>
> For docker
>
> Reviewed-by: Daniel P. Berrangé <address@hidden>
>
>
> Does it need adding to travis, gitlab, shippable, etc CI configs
> too ?

Those are all good, only shippable has an issue with w64 build:

backends/dbus-vmstate.c:313:22: error: format '%u' expects argument of
type 'unsigned int', but argument 3 has type 'gsize {aka long long
unsigned int}' [-Werror=format=]
error_report("%s: Too large vmstate data to save: %" G_GSIZE_FORMAT,

This seems to be a MXE build issue, since build correctly includes
"/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0", and
fedora mingw works. Philippe, any idea?

And I didn't manage to run a Cirrus CI build, help welcome.


-- 
Marc-André Lureau