Re: [PATCH v6 7/8] dockerfiles: add dbus-daemon to some of latest distributions

[Daniel P . Berrangé]

On Thu, Dec 19, 2019 at 04:23:48PM +0400, Marc-André Lureau wrote:
> Hi
> 
> On Thu, Dec 12, 2019 at 4:07 PM Daniel P. Berrangé <address@hidden> wrote:
> >
> > On Wed, Dec 11, 2019 at 05:45:05PM +0400, Marc-André Lureau wrote:
> > > To get dbus-vmstate test covered.
> > >
> > > Signed-off-by: Marc-André Lureau <address@hidden>
> > > ---
> > >  tests/docker/dockerfiles/centos7.docker  | 1 +
> > >  tests/docker/dockerfiles/debian10.docker | 1 +
> > >  tests/docker/dockerfiles/fedora.docker   | 1 +
> > >  tests/docker/dockerfiles/ubuntu.docker   | 1 +
> > >  4 files changed, 4 insertions(+)
> >
> > For docker
> >
> > Reviewed-by: Daniel P. Berrangé <address@hidden>
> >
> >
> > Does it need adding to travis, gitlab, shippable, etc CI configs
> > too ?
> 
> Those are all good, only shippable has an issue with w64 build:
> 
> backends/dbus-vmstate.c:313:22: error: format '%u' expects argument of
> type 'unsigned int', but argument 3 has type 'gsize {aka long long
> unsigned int}' [-Werror=format=]
> error_report("%s: Too large vmstate data to save: %" G_GSIZE_FORMAT,
> 
> This seems to be a MXE build issue, since build correctly includes
> "/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0", and
> fedora mingw works. Philippe, any idea?

There was a bug with one release of glib where they changed the
printf function annotations, but messed up so G_*_FORMAT was
changed when built with meson, but not changed when built with
autotools.

So if MXE uses that broken glib version & builds mingw with
autotools instead of meson it will be impacted:

  https://gitlab.gnome.org/GNOME/glib/issues/1497

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|