[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 18/35] hw/input/ps2: Emit warning when old code is used
From: |
Paolo Bonzini |
Subject: |
Re: [RFC PATCH 18/35] hw/input/ps2: Emit warning when old code is used |
Date: |
Tue, 9 Jun 2020 13:06:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote:
> This code hasn't been QOM'ified yet. Warn the user.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/input/ps2.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/input/ps2.c b/hw/input/ps2.c
> index f8746d2f52..0d84061cae 100644
> --- a/hw/input/ps2.c
> +++ b/hw/input/ps2.c
> @@ -30,7 +30,7 @@
> #include "ui/input.h"
> #include "sysemu/reset.h"
> #include "sysemu/runstate.h"
> -
> +#include "hw/qdev-deprecated.h"
> #include "trace.h"
>
> /* debug PC keyboard */
> @@ -1136,6 +1136,8 @@ void *ps2_kbd_init(void (*update_irq)(void *, int),
> void *update_arg)
> {
> PS2KbdState *s = (PS2KbdState *)g_malloc0(sizeof(PS2KbdState));
>
> + qdev_warn_deprecated_function_used();
> +
> trace_ps2_kbd_init(s);
> s->common.update_irq = update_irq;
> s->common.update_arg = update_arg;
> @@ -1158,6 +1160,8 @@ void *ps2_mouse_init(void (*update_irq)(void *, int),
> void *update_arg)
> {
> PS2MouseState *s = (PS2MouseState *)g_malloc0(sizeof(PS2MouseState));
>
> + qdev_warn_deprecated_function_used();
> +
> trace_ps2_mouse_init(s);
> s->common.update_irq = update_irq;
> s->common.update_arg = update_arg;
>
While the keyboard and mouse are not QOM-ified, of the controllers
(i8042, lasips2, pl050) only lasips2 is not. I would warn there.
Paolo
- [RFC PATCH 14/35] hw/i386/pc: Emit warning when old code is used, (continued)
- [RFC PATCH 14/35] hw/i386/pc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 13/35] hw/dma/soc_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 16/35] hw/input/lasips2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 17/35] hw/input/pckbd: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 15/35] hw/i386/xen/xen-hvm: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 18/35] hw/input/ps2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- Re: [RFC PATCH 18/35] hw/input/ps2: Emit warning when old code is used,
Paolo Bonzini <=
- [RFC PATCH 19/35] hw/input/tsc2005: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 21/35] hw/lm32/lm32_hwsetup: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 20/35] hw/intc/i8259: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 22/35] hw/m68k/mcf520x: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 24/35] hw/misc/cbus: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 23/35] hw/misc/applesmc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08