[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 14/35] hw/i386/pc: Emit warning when old code is used
From: |
Paolo Bonzini |
Subject: |
Re: [RFC PATCH 14/35] hw/i386/pc: Emit warning when old code is used |
Date: |
Tue, 9 Jun 2020 13:08:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote:
> This code hasn't been QOM'ified yet. Warn the user.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/i386/pc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 2128f3d6fe..c71809fd28 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -94,6 +94,7 @@
> #include "vmport.h"
> #include "fw_cfg.h"
> #include "trace.h"
> +#include "hw/qdev-deprecated.h"
>
> GlobalProperty pc_compat_5_0[] = {};
> const size_t pc_compat_5_0_len = G_N_ELEMENTS(pc_compat_5_0);
> @@ -348,6 +349,8 @@ GSIState *pc_gsi_create(qemu_irq **irqs, bool pci_enabled)
> {
> GSIState *s;
>
> + qdev_warn_deprecated_function_used();
> +
> s = g_new0(GSIState, 1);
> if (kvm_ioapic_in_kernel()) {
> kvm_pc_setup_irq_routing(pci_enabled);
>
This one is okay, GSIState is just an array of qemu_irqs.
Paolo
- [RFC PATCH 06/35] hw/timer/arm_timer: Emit warning when old code is used, (continued)
- [RFC PATCH 06/35] hw/timer/arm_timer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 08/35] hw/display/blizzard: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 09/35] hw/display/ramfb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 10/35] hw/display/tc6393xb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 11/35] hw/display/vga-isa-mm: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 04/35] hw/arm/pxa2xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 12/35] hw/dma/etraxfs_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 05/35] hw/arm/nseries: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 14/35] hw/i386/pc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- Re: [RFC PATCH 14/35] hw/i386/pc: Emit warning when old code is used,
Paolo Bonzini <=
- [RFC PATCH 13/35] hw/dma/soc_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 16/35] hw/input/lasips2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 17/35] hw/input/pckbd: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 15/35] hw/i386/xen/xen-hvm: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 18/35] hw/input/ps2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 19/35] hw/input/tsc2005: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08