[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 30/35] hw/ppc/virtex_ml507: Emit warning when old code is
From: |
Paolo Bonzini |
Subject: |
Re: [RFC PATCH 30/35] hw/ppc/virtex_ml507: Emit warning when old code is used |
Date: |
Tue, 9 Jun 2020 13:12:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote:
> This code hasn't been QOM'ified yet. Warn the user.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/ppc/virtex_ml507.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
> index 0dacfcd236..17b8036c38 100644
> --- a/hw/ppc/virtex_ml507.c
> +++ b/hw/ppc/virtex_ml507.c
> @@ -40,7 +40,7 @@
> #include "qemu/log.h"
> #include "qemu/option.h"
> #include "exec/address-spaces.h"
> -
> +#include "hw/qdev-deprecated.h"
> #include "hw/ppc/ppc.h"
> #include "hw/ppc/ppc4xx.h"
> #include "hw/qdev-properties.h"
> @@ -95,6 +95,8 @@ static PowerPCCPU *ppc440_init_xilinx(const char *cpu_type,
> uint32_t sysclk)
> CPUPPCState *env;
> qemu_irq *irqs;
>
> + qdev_warn_deprecated_function_used();
> +
> cpu = POWERPC_CPU(cpu_create(cpu_type));
> env = &cpu->env;
>
>
This one is okay.
Paolo
- Re: [RFC PATCH 23/35] hw/misc/applesmc: Emit warning when old code is used, (continued)
- [RFC PATCH 25/35] hw/nvram/eeprom93xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 26/35] hw/openrisc/cputimer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 27/35] hw/ppc/ppc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 29/35] hw/ppc/ppc_booke: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 28/35] hw/ppc/ppc4xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 30/35] hw/ppc/virtex_ml507: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- Re: [RFC PATCH 30/35] hw/ppc/virtex_ml507: Emit warning when old code is used,
Paolo Bonzini <=
- [RFC PATCH 31/35] hw/sh4: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 32/35] hw/riscv: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 33/35] hw/timer/slavio_timer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 34/35] hw/usb/hcd-musb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 35/35] hw/xtensa/xtfpga: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- Re: [RFC PATCH 00/35] hw/qdev: Warn when using pre-qdev/QOM devices, Peter Maydell, 2020/06/08