[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 27/35] hw/ppc/ppc: Emit warning when old code is used
From: |
Paolo Bonzini |
Subject: |
Re: [RFC PATCH 27/35] hw/ppc/ppc: Emit warning when old code is used |
Date: |
Tue, 9 Jun 2020 13:12:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote:
> This code hasn't been QOM'ified yet. Warn the user.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/ppc/ppc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c
> index 4a11fb1640..39fcf746c5 100644
> --- a/hw/ppc/ppc.c
> +++ b/hw/ppc/ppc.c
> @@ -37,6 +37,7 @@
> #include "kvm_ppc.h"
> #include "migration/vmstate.h"
> #include "trace.h"
> +#include "hw/qdev-deprecated.h"
>
> //#define PPC_DEBUG_IRQ
> //#define PPC_DEBUG_TB
> @@ -1114,6 +1115,8 @@ clk_setup_cb cpu_ppc_tb_init (CPUPPCState *env,
> uint32_t freq)
> PowerPCCPU *cpu = env_archcpu(env);
> ppc_tb_t *tb_env;
>
> + qdev_warn_deprecated_function_used();
> +
> tb_env = g_malloc0(sizeof(ppc_tb_t));
> env->tb_env = tb_env;
> tb_env->flags = PPC_DECR_UNDERFLOW_TRIGGERED;
>
This one is okay.
Paolo
- Re: [RFC PATCH 20/35] hw/intc/i8259: Emit warning when old code is used, (continued)
- [RFC PATCH 22/35] hw/m68k/mcf520x: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 24/35] hw/misc/cbus: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 23/35] hw/misc/applesmc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 25/35] hw/nvram/eeprom93xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 26/35] hw/openrisc/cputimer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 27/35] hw/ppc/ppc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- Re: [RFC PATCH 27/35] hw/ppc/ppc: Emit warning when old code is used,
Paolo Bonzini <=
- [RFC PATCH 29/35] hw/ppc/ppc_booke: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 28/35] hw/ppc/ppc4xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 30/35] hw/ppc/virtex_ml507: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 31/35] hw/sh4: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 32/35] hw/riscv: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 33/35] hw/timer/slavio_timer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08