[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] target/arm: Fix missing temp frees in do_vshll_2sh
From: |
Richard Henderson |
Subject: |
Re: [PATCH 1/7] target/arm: Fix missing temp frees in do_vshll_2sh |
Date: |
Tue, 9 Jun 2020 10:09:39 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/9/20 9:02 AM, Peter Maydell wrote:
> The widenfn() in do_vshll_2sh() does not free the input 32-bit
> TCGv, so we need to do this in the calling code.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
> ---
> target/arm/translate-neon.inc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c
> index 664d3612607..299a61f067b 100644
> --- a/target/arm/translate-neon.inc.c
> +++ b/target/arm/translate-neon.inc.c
> @@ -1624,6 +1624,7 @@ static bool do_vshll_2sh(DisasContext *s,
> arg_2reg_shift *a,
> tmp = tcg_temp_new_i64();
>
> widenfn(tmp, rm0);
> + tcg_temp_free_i32(rm0);
> if (a->shift != 0) {
> tcg_gen_shli_i64(tmp, tmp, a->shift);
> tcg_gen_andi_i64(tmp, tmp, ~widen_mask);
> @@ -1631,6 +1632,7 @@ static bool do_vshll_2sh(DisasContext *s,
> arg_2reg_shift *a,
> neon_store_reg64(tmp, a->vd);
>
> widenfn(tmp, rm1);
> + tcg_temp_free_i32(rm1);
> if (a->shift != 0) {
> tcg_gen_shli_i64(tmp, tmp, a->shift);
> tcg_gen_andi_i64(tmp, tmp, ~widen_mask);
>
- [PATCH 0/7] target/arm: Convert Neon 3-reg-diff to decodetree, Peter Maydell, 2020/06/09
- [PATCH 5/7] target/arm: Convert Neon 3-reg-diff long multiplies, Peter Maydell, 2020/06/09
- [PATCH 4/7] target/arm: Convert Neon 3-reg-diff VABAL, VABDL to decodetree, Peter Maydell, 2020/06/09
- [PATCH 2/7] target/arm: Convert Neon 3-reg-diff prewidening ops to decodetree, Peter Maydell, 2020/06/09
- [PATCH 3/7] target/arm: Convert Neon 3-reg-diff narrowing ops to decodetree, Peter Maydell, 2020/06/09
- [PATCH 1/7] target/arm: Fix missing temp frees in do_vshll_2sh, Peter Maydell, 2020/06/09
- [PATCH 6/7] target/arm: Convert Neon 3-reg-diff saturating doubling multiplies, Peter Maydell, 2020/06/09
- [PATCH 7/7] target/arm: Convert Neon 3-reg-diff polynomial VMULL, Peter Maydell, 2020/06/09
- Re: [PATCH 0/7] target/arm: Convert Neon 3-reg-diff to decodetree, no-reply, 2020/06/09
- Re: [PATCH 0/7] target/arm: Convert Neon 3-reg-diff to decodetree, no-reply, 2020/06/09
- Re: [PATCH 0/7] target/arm: Convert Neon 3-reg-diff to decodetree, no-reply, 2020/06/09
- Re: [PATCH 0/7] target/arm: Convert Neon 3-reg-diff to decodetree, no-reply, 2020/06/09
- Re: [PATCH 0/7] target/arm: Convert Neon 3-reg-diff to decodetree, no-reply, 2020/06/09