[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/7] target/arm: Convert Neon 3-reg-diff prewidening ops to d
From: |
Richard Henderson |
Subject: |
Re: [PATCH 2/7] target/arm: Convert Neon 3-reg-diff prewidening ops to decodetree |
Date: |
Tue, 9 Jun 2020 10:26:51 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/9/20 9:02 AM, Peter Maydell wrote:
+#define DO_PREWIDEN(INSN, S, EXT, OP, SRC1WIDE) \
> + static bool trans_##INSN##_3d(DisasContext *s, arg_3diff *a) \
> + { \
> + NeonGenWidenFn *widenfn[] = { \
> + gen_helper_neon_widen_##S##8, \
> + gen_helper_neon_widen_##S##16, \
> + tcg_gen_##EXT##_i32_i64, \
> + NULL, \
> + }; \
> + NeonGenTwo64OpFn *addfn[] = { \
Missing const here.
Actually, patch 1 made me look back and we missed it, and static, in
trans_VSHLL_*_2sh.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH 0/7] target/arm: Convert Neon 3-reg-diff to decodetree, Peter Maydell, 2020/06/09
- [PATCH 5/7] target/arm: Convert Neon 3-reg-diff long multiplies, Peter Maydell, 2020/06/09
- [PATCH 4/7] target/arm: Convert Neon 3-reg-diff VABAL, VABDL to decodetree, Peter Maydell, 2020/06/09
- [PATCH 2/7] target/arm: Convert Neon 3-reg-diff prewidening ops to decodetree, Peter Maydell, 2020/06/09
- Re: [PATCH 2/7] target/arm: Convert Neon 3-reg-diff prewidening ops to decodetree,
Richard Henderson <=
- [PATCH 3/7] target/arm: Convert Neon 3-reg-diff narrowing ops to decodetree, Peter Maydell, 2020/06/09
- [PATCH 1/7] target/arm: Fix missing temp frees in do_vshll_2sh, Peter Maydell, 2020/06/09
- [PATCH 6/7] target/arm: Convert Neon 3-reg-diff saturating doubling multiplies, Peter Maydell, 2020/06/09
- [PATCH 7/7] target/arm: Convert Neon 3-reg-diff polynomial VMULL, Peter Maydell, 2020/06/09
- Re: [PATCH 0/7] target/arm: Convert Neon 3-reg-diff to decodetree, no-reply, 2020/06/09