Re: [PULL 000/115] Huge miscellaneous pull request for 2020-06-11

[Peter Maydell]

On Thu, 11 Jun 2020 at 21:19, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The following changes since commit 31d321c2b3574dcc74e9f6411af06bca6b5d10f4:
>
>   Merge remote-tracking branch 
> 'remotes/philmd-gitlab/tags/sparc-next-20200609' into staging (2020-06-09 
> 17:29:47 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to d3ffb42f3fbe24c29a2bd7806dab1dd521b4d59c:
>
>   target/i386: Remove obsolete TODO file (2020-06-11 14:08:59 -0400)
>
> ----------------------------------------------------------------
> * Miscellaneous fixes and feature enablement (many)
> * SEV refactoring (David)
> * Hyper-V initial support (Jon)
> * i386 TCG fixes (x87 and SSE, Joseph)
> * vmport cleanup and improvements (Philippe, Liran)
> * Use-after-free with vCPU hot-unplug (Nengyuan)
> * run-coverity-scan improvements (myself)
> * Record/replay fixes (Pavel)
> * -machine kernel_irqchip=split improvements for INTx (Peter)
> * Code cleanups (Philippe)
> * Crash and security fixes (PJP)
> * HVF cleanups (Roman)
>

Hi; I'm afraid this fails to build on OSX, and has a check-tcg
failure on x86-64 Linux.

OSX:

In file included from /Users/pm215/src/qemu-for-merges/target/i386/hvf/hvf.c:53:
In file included from /Users/pm215/src/qemu-for-merges/include/sysemu/hvf.h:16:
/Users/pm215/src/qemu-for-merges/target/i386/cpu.h:1601:5: error:
unknown type name 'hvf_lazy_flags'
    hvf_lazy_flags hvf_lflags;
    ^
In file included from /Users/pm215/src/qemu-for-merges/target/i386/hvf/hvf.c:53:
In file included from /Users/pm215/src/qemu-for-merges/include/sysemu/hvf.h:16:
In file included from /Users/pm215/src/qemu-for-merges/target/i386/cpu.h:2021:
/Users/pm215/src/qemu-for-merges/include/exec/cpu-all.h:442:12: error:
returning 'void' from a function with incompatible result type
'ArchCPU *' (aka 'struct X86CPU *')
    return container_of(env, ArchCPU, env);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/pm215/src/qemu-for-merges/include/qemu/compiler.h:56:41: note:
expanded from macro 'container_of'
#define container_of(ptr, type, member) ({                      \
                                        ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /Users/pm215/src/qemu-for-merges/target/i386/hvf/hvf.c:53:
In file included from /Users/pm215/src/qemu-for-merges/include/sysemu/hvf.h:16:
In file included from /Users/pm215/src/qemu-for-merges/target/i386/cpu.h:2021:
/Users/pm215/src/qemu-for-merges/include/exec/cpu-all.h:464:14: error:
initializing 'ArchCPU *' (aka 'struct X86CPU *') with an expression of
incompatible type 'void'
    ArchCPU *arch_cpu = container_of(env, ArchCPU, env);
             ^          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.


On x86-64 Linux host, running the check-tcg tests on the static
linux-user build:

  BUILD   i386-linux-user guest-tests with docker qemu:fedora-i386-cross
/home/petmay01/linaro/qemu-for-merges/tests/tcg/i386/test-i386-pcmpistri.c:
In function 'main':
/home/petmay01/linaro/qemu-for-merges/tests/tcg/i386/test-i386-pcmpistri.c:28:15:
warning: left-hand operand of comma expression has no effect
[-Wunused-value]
   28 |     if ("%d\n", _mm_cmpistri(s1.x, s3.x, 0x4c) != 16) {
      |               ^

(only a warning because we don't seem to be using -Werror here?)

and then the test crashed at runtime:

  TEST    test-i386-pcmpistri on i386
qemu: uncaught target signal 4 (Illegal instruction) - core dumped
timeout: the monitored command dumped core
Illegal instruction
../Makefile.target:151: recipe for target 'run-test-i386-pcmpistri' failed


thanks
-- PMM