[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 000/115] Huge miscellaneous pull request for 2020-06-11
From: |
Paolo Bonzini |
Subject: |
Re: [PULL 000/115] Huge miscellaneous pull request for 2020-06-11 |
Date: |
Fri, 12 Jun 2020 15:33:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 12/06/20 15:09, Peter Maydell wrote:
> Hi; I'm afraid this fails to build on OSX, and has a check-tcg
> failure on x86-64 Linux.
>
> OSX:
>
> In file included from
> /Users/pm215/src/qemu-for-merges/target/i386/hvf/hvf.c:53:
> In file included from
> /Users/pm215/src/qemu-for-merges/include/sysemu/hvf.h:16:
> /Users/pm215/src/qemu-for-merges/target/i386/cpu.h:1601:5: error:
> unknown type name 'hvf_lazy_flags'
> hvf_lazy_flags hvf_lflags;
> ^
> In file included from
> /Users/pm215/src/qemu-for-merges/target/i386/hvf/hvf.c:53:
> In file included from
> /Users/pm215/src/qemu-for-merges/include/sysemu/hvf.h:16:
> In file included from /Users/pm215/src/qemu-for-merges/target/i386/cpu.h:2021:
> /Users/pm215/src/qemu-for-merges/include/exec/cpu-all.h:442:12: error:
> returning 'void' from a function with incompatible result type
> 'ArchCPU *' (aka 'struct X86CPU *')
> return container_of(env, ArchCPU, env);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /Users/pm215/src/qemu-for-merges/include/qemu/compiler.h:56:41: note:
> expanded from macro 'container_of'
> #define container_of(ptr, type, member) ({ \
> ^~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from
> /Users/pm215/src/qemu-for-merges/target/i386/hvf/hvf.c:53:
> In file included from
> /Users/pm215/src/qemu-for-merges/include/sysemu/hvf.h:16:
> In file included from /Users/pm215/src/qemu-for-merges/target/i386/cpu.h:2021:
> /Users/pm215/src/qemu-for-merges/include/exec/cpu-all.h:464:14: error:
> initializing 'ArchCPU *' (aka 'struct X86CPU *') with an expression of
> incompatible type 'void'
> ArchCPU *arch_cpu = container_of(env, ArchCPU, env);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 3 errors generated.
>
>
> On x86-64 Linux host, running the check-tcg tests on the static
> linux-user build:
>
> BUILD i386-linux-user guest-tests with docker qemu:fedora-i386-cross
> /home/petmay01/linaro/qemu-for-merges/tests/tcg/i386/test-i386-pcmpistri.c:
> In function 'main':
> /home/petmay01/linaro/qemu-for-merges/tests/tcg/i386/test-i386-pcmpistri.c:28:15:
> warning: left-hand operand of comma expression has no effect
> [-Wunused-value]
> 28 | if ("%d\n", _mm_cmpistri(s1.x, s3.x, 0x4c) != 16) {
> | ^
>
> (only a warning because we don't seem to be using -Werror here?)
>
> and then the test crashed at runtime:
>
> TEST test-i386-pcmpistri on i386
> qemu: uncaught target signal 4 (Illegal instruction) - core dumped
> timeout: the monitored command dumped core
> Illegal instruction
> ../Makefile.target:151: recipe for target 'run-test-i386-pcmpistri' failed
I'll resend without the offending patch. Roman, Joseph, please take a
look and (especially for the OS X) please check if your series need a
rebase.
Thanks,
Paolo
- [PULL 110/115] exec/memory: Remove unused MemoryRegionMmio type, (continued)
- [PULL 110/115] exec/memory: Remove unused MemoryRegionMmio type, Paolo Bonzini, 2020/06/11
- [PULL 114/115] stubs: move Xen stubs to accel/, Paolo Bonzini, 2020/06/11
- [PULL 111/115] hw/usb: Move device-specific declarations to new 'hcd-musb.h' header, Paolo Bonzini, 2020/06/11
- [PULL 113/115] replay: fix replay shutdown for console mode, Paolo Bonzini, 2020/06/11
- [PULL 112/115] exec/cpu-common: Move MUSB specific typedefs to 'hw/usb/hcd-musb.h', Paolo Bonzini, 2020/06/11
- [PULL 115/115] target/i386: Remove obsolete TODO file, Paolo Bonzini, 2020/06/11
- [PULL 086/115] target/ppc: Restrict PPCVirtualHypervisorClass to system-mode, Paolo Bonzini, 2020/06/11
- [PULL 106/115] target/i386: sev: Remove redundant policy field, Paolo Bonzini, 2020/06/11
- Re: [PULL 000/115] Huge miscellaneous pull request for 2020-06-11, no-reply, 2020/06/11
- Re: [PULL 000/115] Huge miscellaneous pull request for 2020-06-11, Peter Maydell, 2020/06/12
- Re: [PULL 000/115] Huge miscellaneous pull request for 2020-06-11,
Paolo Bonzini <=