Re: [PATCH v3 4/7] hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1

[Richard Henderson]

On 6/20/20 4:07 PM, Philippe Mathieu-Daudé wrote:
> The Witherspoon has 3 LEDs connected to a PCA9552. Add them.
> The names and reset values are taken from:
> https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml
> 
> Example booting obmc-phosphor-image:
> 
>   $ qemu-system-arm -M witherspoon-bmc -trace led_change_intensity
>   1592693373.997015:led_change_intensity LED desc:'front-fault-4' color:green 
> intensity 0x0000 -> 0xffff
>   1592693373.997632:led_change_intensity LED desc:'front-power-3' color:green 
> intensity 0x0000 -> 0xffff
>   1592693373.998239:led_change_intensity LED desc:'front-id-5' color:green 
> intensity 0x0000 -> 0xffff
>   1592693500.291805:led_change_intensity LED desc:'front-power-3' color:green 
> intensity 0xffff -> 0x0000
>   1592693500.312041:led_change_intensity LED desc:'front-power-3' color:green 
> intensity 0x0000 -> 0xffff
>   1592693500.821254:led_change_intensity LED desc:'front-power-3' color:green 
> intensity 0xffff -> 0x0000
>   1592693501.331517:led_change_intensity LED desc:'front-power-3' color:green 
> intensity 0x0000 -> 0xffff
>   1592693501.841367:led_change_intensity LED desc:'front-power-3' color:green 
> intensity 0xffff -> 0x0000
>   1592693502.350839:led_change_intensity LED desc:'front-power-3' color:green 
> intensity 0x0000 -> 0xffff
>   1592693502.861134:led_change_intensity LED desc:'front-power-3' color:green 
> intensity 0xffff -> 0x0000
>   1592693503.371090:led_change_intensity LED desc:'front-power-3' color:green 
> intensity 0x0000 -> 0xffff
> 
> We notice the front-power LED starts to blink.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/arm/aspeed.c | 17 +++++++++++++++++
>  hw/arm/Kconfig  |  1 +
>  2 files changed, 18 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~