|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH v3 5/7] hw/misc/mps2-fpgaio: Use the LED device |
Date: | Sun, 21 Jun 2020 23:09:43 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/21/20 11:00 PM, Richard Henderson wrote: > On 6/20/20 4:07 PM, Philippe Mathieu-Daudé wrote: >> + DeviceState *led[2]; > > Perhaps better as LEDState? And perhaps return that from create_led. I guess I first thought about using an opaque structure with forward typedef declaration, but in this case I also prefer your suggestion. Thanks :)
[Prev in Thread] | Current Thread | [Next in Thread] |