[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 04/10] virtio-pci: implement queue_enabled method
From: |
Cindy Lu |
Subject: |
Re: [PATCH v1 04/10] virtio-pci: implement queue_enabled method |
Date: |
Tue, 23 Jun 2020 17:18:14 +0800 |
On Tue, Jun 23, 2020 at 3:13 PM Jason Wang <jasowang@redhat.com> wrote:
>
>
> On 2020/6/22 下午11:37, Cindy Lu wrote:
> > From: Jason Wang <jasowang@redhat.com>
> >
> > With version 1, we can detect whether a queue is enabled via
> > queue_enabled.
> >
> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > Signed-off-by: Cindy Lu <lulu@redhat.com>
> > ---
> > hw/virtio/virtio-pci.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> > index 4cb784389c..3918aa9f6c 100644
> > --- a/hw/virtio/virtio-pci.c
> > +++ b/hw/virtio/virtio-pci.c
> > @@ -1107,6 +1107,23 @@ static AddressSpace
> > *virtio_pci_get_dma_as(DeviceState *d)
> > return pci_get_address_space(dev);
> > }
> >
> > +static bool virtio_queue_check_enabled(VirtIODevice *vdev, int n)
>
>
> One space is sufficient between bool and virtio_queue_check_enabled.
>
>
> > +{
> > + return virtio_queue_get_desc_addr(vdev, n) != 0;
> > +}
> > +
> > +static bool virtio_pci_queue_enabled(DeviceState *d, int n)
> > +{
> > + VirtIOPCIProxy *proxy = VIRTIO_PCI(d);
> > + VirtIODevice *vdev = virtio_bus_get_device(&proxy->bus);
> > +
> > + if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) {
> > + return proxy->vqs[vdev->queue_sel].enabled;
> > + }
> > +
> > + return virtio_queue_check_enabled(vdev, n);
>
>
> Similar issue here.
>
> Thanks
>
Thanks, I will correct this
>
> > +}
> > +
> > static int virtio_pci_add_mem_cap(VirtIOPCIProxy *proxy,
> > struct virtio_pci_cap *cap)
> > {
> > @@ -2059,6 +2076,7 @@ static void virtio_pci_bus_class_init(ObjectClass
> > *klass, void *data)
> > k->ioeventfd_enabled = virtio_pci_ioeventfd_enabled;
> > k->ioeventfd_assign = virtio_pci_ioeventfd_assign;
> > k->get_dma_as = virtio_pci_get_dma_as;
> > + k->queue_enabled = virtio_pci_queue_enabled;
> > }
> >
> > static const TypeInfo virtio_pci_bus_info = {
>
- [PATCH v1 00/10] vDPA support in qemu, Cindy Lu, 2020/06/22
- [PATCH v1 01/10] net: introduce qemu_get_peer, Cindy Lu, 2020/06/22
- [PATCH v1 02/10] vhost_net: use the function qemu_get_peer, Cindy Lu, 2020/06/22
- [PATCH v1 03/10] virtio-bus: introduce queue_enabled method, Cindy Lu, 2020/06/22
- [PATCH v1 04/10] virtio-pci: implement queue_enabled method, Cindy Lu, 2020/06/22
- [PATCH v1 05/10] vhost-backend: export the vhost backend helper, Cindy Lu, 2020/06/22
- [PATCH v1 06/10] vhsot_net: introduce set_config & get_config function, Cindy Lu, 2020/06/22
- [PATCH v1 07/10] vhost: introduce new VhostOps vhost_dev_start, Cindy Lu, 2020/06/22
- [PATCH v1 08/10] vhost: implement vhost_dev_start method, Cindy Lu, 2020/06/22