[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 04/10] virtio-pci: implement queue_enabled method
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v1 04/10] virtio-pci: implement queue_enabled method |
Date: |
Wed, 24 Jun 2020 15:24:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 22/06/2020 17:37, Cindy Lu wrote:
> From: Jason Wang <jasowang@redhat.com>
>
> With version 1, we can detect whether a queue is enabled via
> queue_enabled.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Cindy Lu <lulu@redhat.com>
> ---
> hw/virtio/virtio-pci.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index 4cb784389c..3918aa9f6c 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -1107,6 +1107,23 @@ static AddressSpace *virtio_pci_get_dma_as(DeviceState
> *d)
> return pci_get_address_space(dev);
> }
>
> +static bool virtio_queue_check_enabled(VirtIODevice *vdev, int n)
> +{
> + return virtio_queue_get_desc_addr(vdev, n) != 0;
> +}
This function is already defined under a different name in
hw/virtio/virtio.c:
3287 bool virtio_queue_enabled(VirtIODevice *vdev, int n)
3288 {
3289 return virtio_queue_get_desc_addr(vdev, n) != 0;
3290 }
As this file includes "hw/virtio/virtio.h" you can use it directly.
Thanks,
Laurent
- [PATCH v1 00/10] vDPA support in qemu, Cindy Lu, 2020/06/22
- [PATCH v1 01/10] net: introduce qemu_get_peer, Cindy Lu, 2020/06/22
- [PATCH v1 02/10] vhost_net: use the function qemu_get_peer, Cindy Lu, 2020/06/22
- [PATCH v1 03/10] virtio-bus: introduce queue_enabled method, Cindy Lu, 2020/06/22
- [PATCH v1 04/10] virtio-pci: implement queue_enabled method, Cindy Lu, 2020/06/22
- [PATCH v1 05/10] vhost-backend: export the vhost backend helper, Cindy Lu, 2020/06/22
- [PATCH v1 06/10] vhsot_net: introduce set_config & get_config function, Cindy Lu, 2020/06/22
- [PATCH v1 07/10] vhost: introduce new VhostOps vhost_dev_start, Cindy Lu, 2020/06/22
- [PATCH v1 08/10] vhost: implement vhost_dev_start method, Cindy Lu, 2020/06/22