[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libqos: pci-pc: use 32-bit write for EJ register
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PATCH] libqos: pci-pc: use 32-bit write for EJ register |
|
Date: |
Tue, 23 Jun 2020 16:55:48 -0400 |
On Tue, Jun 23, 2020 at 12:18:51PM -0400, Paolo Bonzini wrote:
> The memory region ops have min_access_size == 4 so obey it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
I assume you are queueing this with the memory core change?
> ---
> tests/qtest/libqos/pci-pc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/libqos/pci-pc.c b/tests/qtest/libqos/pci-pc.c
> index 0bc591d1da..3bb2eb3ba8 100644
> --- a/tests/qtest/libqos/pci-pc.c
> +++ b/tests/qtest/libqos/pci-pc.c
> @@ -186,7 +186,7 @@ void qpci_unplug_acpi_device_test(QTestState *qts, const
> char *id, uint8_t slot)
> g_assert(!qdict_haskey(response, "error"));
> qobject_unref(response);
>
> - qtest_outb(qts, ACPI_PCIHP_ADDR + PCI_EJ_BASE, 1 << slot);
> + qtest_outl(qts, ACPI_PCIHP_ADDR + PCI_EJ_BASE, 1 << slot);
>
> qtest_qmp_eventwait(qts, "DEVICE_DELETED");
> }
> --
> 2.26.2