[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libqos: pci-pc: use 32-bit write for EJ register
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH] libqos: pci-pc: use 32-bit write for EJ register |
Date: |
Wed, 24 Jun 2020 07:59:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 23/06/20 22:55, Michael S. Tsirkin wrote:
> On Tue, Jun 23, 2020 at 12:18:51PM -0400, Paolo Bonzini wrote:
>> The memory region ops have min_access_size == 4 so obey it.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> I assume you are queueing this with the memory core change?
Yes, I am.
>
>> ---
>> tests/qtest/libqos/pci-pc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/qtest/libqos/pci-pc.c b/tests/qtest/libqos/pci-pc.c
>> index 0bc591d1da..3bb2eb3ba8 100644
>> --- a/tests/qtest/libqos/pci-pc.c
>> +++ b/tests/qtest/libqos/pci-pc.c
>> @@ -186,7 +186,7 @@ void qpci_unplug_acpi_device_test(QTestState *qts, const
>> char *id, uint8_t slot)
>> g_assert(!qdict_haskey(response, "error"));
>> qobject_unref(response);
>>
>> - qtest_outb(qts, ACPI_PCIHP_ADDR + PCI_EJ_BASE, 1 << slot);
>> + qtest_outl(qts, ACPI_PCIHP_ADDR + PCI_EJ_BASE, 1 << slot);
>>
>> qtest_qmp_eventwait(qts, "DEVICE_DELETED");
>> }
>> --
>> 2.26.2
>