[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/9] tz-ppc: add dummy read/write methods
From: |
P J P |
Subject: |
Re: [PATCH v2 7/9] tz-ppc: add dummy read/write methods |
Date: |
Thu, 25 Jun 2020 14:48:32 +0530 (IST) |
+-- On Thu, 25 Jun 2020, Philippe Mathieu-Daudé wrote --+
| > @@ -196,7 +196,22 @@ static bool tz_ppc_dummy_accepts(void *opaque, hwaddr
addr,
| > g_assert_not_reached();
|
| This is a shame we now have to fill the read/write handlers for
| unreachable code :(
|
| > +static uint64_t tz_ppc_dummy_read(void *opaque, hwaddr addr, unsigned size)
|
| I'd instead use a clearer:
| g_assert_not_reached();
|
| > +static void tz_ppc_dummy_write(void *opaque, hwaddr addr,
|
| Ditto:
| g_assert_not_reached();
This will likely be called in tz_ppc_dummy_accepts() above. Do we still want
to revise this patch? considering read/write callbacks are unreachable.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D
- [PATCH v2 1/9] hw/pci-host: add pci-intack write method, (continued)
- [PATCH v2 1/9] hw/pci-host: add pci-intack write method, P J P, 2020/06/24
- [PATCH v2 3/9] vfio: add quirk device write method, P J P, 2020/06/24
- [PATCH v2 2/9] pci-host: add pcie-msi read method, P J P, 2020/06/24
- [PATCH v2 9/9] memory: assert MemoryRegionOps callbacks are defined, P J P, 2020/06/24
- [PATCH v2 7/9] tz-ppc: add dummy read/write methods, P J P, 2020/06/24
[PATCH v2 4/9] prep: add ppc-parity write method, P J P, 2020/06/24