[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/9] prep: add ppc-parity write method
From: |
Li Qiang |
Subject: |
Re: [PATCH v2 4/9] prep: add ppc-parity write method |
Date: |
Mon, 29 Jun 2020 19:22:59 +0800 |
P J P <ppandit@redhat.com> 于2020年6月25日周四 上午3:00写道:
>
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> Add ppc-parity mmio write method to avoid NULL pointer dereference
> issue.
>
> Reported-by: Lei Sun <slei.casper@gmail.com>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> hw/ppc/prep_systemio.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> Update v2: use LOG_GUEST_ERROR
> -> https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg04975.html
>
> diff --git a/hw/ppc/prep_systemio.c b/hw/ppc/prep_systemio.c
> index bbc51b6e9a..03a2f8af6e 100644
> --- a/hw/ppc/prep_systemio.c
> +++ b/hw/ppc/prep_systemio.c
> @@ -23,6 +23,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "hw/irq.h"
> #include "hw/isa/isa.h"
> #include "hw/qdev-properties.h"
> @@ -235,8 +236,15 @@ static uint64_t ppc_parity_error_readl(void *opaque,
> hwaddr addr,
> return val;
> }
>
> +static void ppc_parity_error_writel(void *opaque, hwaddr addr,
> + uint64_t data, unsigned size)
> +{
> + qemu_log_mask(LOG_GUEST_ERROR, "%s not implemented\n", __func__);
> +}
I'm not familiar with this platform-related stuff. I think a
'qemu_log_mask(LOG_UNIMP, xxx)' is ok.
Thanks,
Li Qiang
> +
> static const MemoryRegionOps ppc_parity_error_ops = {
> .read = ppc_parity_error_readl,
> + .write = ppc_parity_error_writel,
> .valid = {
> .min_access_size = 4,
> .max_access_size = 4,
> --
> 2.26.2
>
[PATCH v2 4/9] prep: add ppc-parity write method, P J P, 2020/06/24
[PATCH v2 5/9] nvram: add nrf51_soc flash read method, P J P, 2020/06/24
Re: [PATCH v2 5/9] nvram: add nrf51_soc flash read method, Paolo Bonzini, 2020/06/29
[PATCH v2 6/9] spapr_pci: add spapr msi read method, P J P, 2020/06/24
[PATCH v2 8/9] imx7-ccm: add digprog mmio write method, P J P, 2020/06/24