[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] meson: use pkg-config method to find dependencies
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH] meson: use pkg-config method to find dependencies |
Date: |
Tue, 1 Sep 2020 07:00:36 +0200 |
On Mon, Aug 31, 2020 at 02:15:23PM +0200, Paolo Bonzini wrote:
> On 31/08/20 13:06, Gerd Hoffmann wrote:
> >
> >> Keep "auto" for SDL so that it tries using
> >> sdl-config too.
> >> - sdl = dependency('sdl2',
> >> - required: get_option('sdl'),
> >> + sdl = dependency('sdl2', required: get_option('sdl'),
> >> + method: 'pkg-config',
> > code and commit message mismatch here.
>
> That's docs/devel/build-system.rst,
Oops, missed that, sorry.
> I wanted to keep the "method" so
> that people can cut-and-paste correctly.
>
> Would you prefer if I switched from sdl2 to something else (for example
> pixman which has a "version" keyword argument as well)?
Sounds like a good idea to me.
take care,
Gerd
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH] meson: use pkg-config method to find dependencies,
Gerd Hoffmann <=