qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cirrus: handle wraparound in cirrus_invalidate_region


From: Gerd Hoffmann
Subject: Re: [PATCH] cirrus: handle wraparound in cirrus_invalidate_region
Date: Tue, 1 Sep 2020 07:15:30 +0200

  Hi,

> > > >          off_cur_end = ((off_cur + bytesperline - 1) & 
> > > > s->cirrus_addr_mask) + 1;
[ ... ]
> > > > +            memory_region_set_dirty(&s->vga.vram, 0, off_cur_end);
> > >
> > > And here be 'off_cur_end -1'
> >
> > --verbose please.  I think this one is correct.
> 
> Here the 'off_cur_end' is size.

Exactly.  And memory_region_set_dirty wants the size.  So everything is
fine, right?

take care,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]