Re: [PATCH] cirrus: handle wraparound in cirrus_invalidate_region

[Gerd Hoffmann]

On Tue, Sep 01, 2020 at 03:37:17PM +0800, Li Qiang wrote:
> Gerd Hoffmann <kraxel@redhat.com> 于2020年9月1日周二 下午3:16写道：
> >
> >   Hi,
> >
> > > +            /* wraparound */
> > > +            memory_region_set_dirty(&s->vga.vram, off_cur,
> > > s->cirrus_addr_mask - off_cur);
> >
> > > So the len is 's->cirrus_addr_mask->off_cur+1'.
> >
> > Correct.
> 
> So do you agree me the first set size should be 's->cirrus_addr_mask -
> off_cur+1'?

Yes.

> > The +1 balances the -1 done before ...
> 
> Then the second set size is ok.

Ok, good.  v2 sent now.

thanks,
  Gerd