[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/20] ftgmac100: Change interrupt status when a DMA error occurs
From: |
Cédric Le Goater |
Subject: |
[PULL 11/20] ftgmac100: Change interrupt status when a DMA error occurs |
Date: |
Tue, 1 Sep 2020 14:45:16 +0200 |
The model uses today the "Normal priority transmit buffer unavailable"
interrupt status which it is not appropriate. According to the Aspeed
specs, no interrupts are raised in that case. An "AHB error" status
seems like a better modeling choice for all implementations since it
is covered by the Linux kernel.
Cc: Frederic Konrad <konrad.frederic@yahoo.fr>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Message-Id: <20200819100956.2216690-13-clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/net/ftgmac100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c
index 5c0fe2d8cb75..014980d30aca 100644
--- a/hw/net/ftgmac100.c
+++ b/hw/net/ftgmac100.c
@@ -517,7 +517,7 @@ static void ftgmac100_do_tx(FTGMAC100State *s, uint32_t
tx_ring,
if (dma_memory_read(&address_space_memory, bd.des3, ptr, len)) {
qemu_log_mask(LOG_GUEST_ERROR, "%s: failed to read packet @
0x%x\n",
__func__, bd.des3);
- s->isr |= FTGMAC100_INT_NO_NPTXBUF;
+ s->isr |= FTGMAC100_INT_AHB_ERR;
break;
}
--
2.25.4
- [PULL 15/20] aspeed/sdmc: Perform memory training, (continued)
- [PULL 15/20] aspeed/sdmc: Perform memory training, Cédric Le Goater, 2020/09/01
- [PULL 16/20] aspeed/sdmc: Allow writes to unprotected registers, Cédric Le Goater, 2020/09/01
- [PULL 14/20] ftgmac100: Improve software reset, Cédric Le Goater, 2020/09/01
- [PULL 09/20] ftgmac100: Fix interrupt status "Packet transmitted on ethernet", Cédric Le Goater, 2020/09/01
- [PULL 18/20] aspeed/smc: Open AHB window of the second chip of the AST2600 FMC controller, Cédric Le Goater, 2020/09/01
- [PULL 20/20] hw: add a number of SPI-flash's of m25p80 family, Cédric Le Goater, 2020/09/01
- [PULL 10/20] ftgmac100: Fix interrupt status "Packet moved to RX FIFO", Cédric Le Goater, 2020/09/01
- [PULL 13/20] ftgmac100: Fix integer overflow in ftgmac100_do_tx(), Cédric Le Goater, 2020/09/01
- [PULL 19/20] arm: aspeed: add strap define `25HZ` of AST2500, Cédric Le Goater, 2020/09/01
- [PULL 17/20] aspeed/sdmc: Simplify calculation of RAM bits, Cédric Le Goater, 2020/09/01
- [PULL 11/20] ftgmac100: Change interrupt status when a DMA error occurs,
Cédric Le Goater <=
- Re: [PULL 00/20] aspeed queue, Peter Maydell, 2020/09/03