Re: [PATCH v8 29/43] mirror: Deal with filters

[Kevin Wolf]

Am 01.09.2020 um 16:34 hat Max Reitz geschrieben:
> This includes some permission limiting (for example, we only need to
> take the RESIZE permission for active commits where the base is smaller
> than the top).
> 
> base_overlay is introduced so we can query bdrv_is_allocated_above() on
> it - we cannot do that with base itself, because a filter's block_status
> is the same as its child node, so if there are filters on base,
> bdrv_is_allocated_above() on base would return information including
> base.
> 
> Use this opportunity to rename qmp_drive_mirror()'s "source" BDS to
> "target_backing_bs", because that is what it really refers to.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>

I see that you decided not to fix the missing freeze of the backing
chain on the source side. I'm willing to view this as a pre-existing
issue that shouldn't stop this series, but are you going to send a
separate patch for it?

Kevin