[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] usb/host-libusb: Check for USBDEVFS_GET_SPEED ioctl support
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] usb/host-libusb: Check for USBDEVFS_GET_SPEED ioctl support |
|
Date: |
Wed, 2 Sep 2020 14:15:34 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/2/20 2:16 PM, Sai Pavan Boddu wrote:
> Fixes compilation issue with older kernels, below is the error which is
> fixed.
>
> hw/usb/host-libusb.c:954:32: error: ‘USBDEVFS_GET_SPEED’ undeclared
> (first use in this function)
> int rc = ioctl(hostfd, USBDEVFS_GET_SPEED, NULL);
>
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> ---
> hw/usb/host-libusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
> index 08604f7..c30d450 100644
> --- a/hw/usb/host-libusb.c
> +++ b/hw/usb/host-libusb.c
> @@ -942,7 +942,7 @@ static int usb_host_open(USBHostDevice *s, libusb_device
> *dev, int hostfd)
> usb_host_ep_update(s);
>
> libusb_speed = libusb_get_device_speed(dev);
> -#ifdef CONFIG_LINUX
> +#if defined(CONFIG_LINUX) && defined(USBDEVFS_GET_SPEED)
Gerd recently sent a slightly different patch:
https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg00649.html
> if (hostfd && libusb_speed == 0) {
> /*
> * Workaround libusb bug: libusb_get_device_speed() does not
>