RE: [PATCH] usb/host-libusb: Check for USBDEVFS_GET_SPEED ioctl support

[Sai Pavan Boddu]

HI Philippe/Gerd,

Thanks, 
This patch can be ignored then.

Regards,
Sai Pavan

> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: Wednesday, September 2, 2020 5:46 PM
> To: Sai Pavan Boddu <saipava@xilinx.com>; Peter Maydell
> <peter.maydell@linaro.org>; Markus Armbruster <armbru@redhat.com>;
> 'Marc-André Lureau' <marcandre.lureau@redhat.com>; Paolo Bonzini
> <pbonzini@redhat.com>; Gerd Hoffmann <kraxel@redhat.com>; Edgar
> Iglesias <edgari@xilinx.com>; Francisco Eduardo Iglesias
> <figlesia@xilinx.com>
> Cc: qemu-devel@nongnu.org; Alistair Francis <alistair.francis@wdc.com>;
> Eduardo Habkost <ehabkost@redhat.com>; Ying Fang
> <fangying1@huawei.com>; Vikram Garhwal <fnuv@xilinx.com>; Paul
> Zimmerman <pauldzim@gmail.com>
> Subject: Re: [PATCH] usb/host-libusb: Check for USBDEVFS_GET_SPEED ioctl
> support
> 
> On 9/2/20 2:16 PM, Sai Pavan Boddu wrote:
> > Fixes compilation issue with older kernels, below is the error which
> > is fixed.
> >
> > hw/usb/host-libusb.c:954:32: error: ‘USBDEVFS_GET_SPEED’ undeclared
> > (first use in this function)
> >          int rc = ioctl(hostfd, USBDEVFS_GET_SPEED, NULL);
> >
> > Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> > ---
> >  hw/usb/host-libusb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index
> > 08604f7..c30d450 100644
> > --- a/hw/usb/host-libusb.c
> > +++ b/hw/usb/host-libusb.c
> > @@ -942,7 +942,7 @@ static int usb_host_open(USBHostDevice *s,
> libusb_device *dev, int hostfd)
> >      usb_host_ep_update(s);
> >
> >      libusb_speed = libusb_get_device_speed(dev); -#ifdef CONFIG_LINUX
> > +#if defined(CONFIG_LINUX) && defined(USBDEVFS_GET_SPEED)
> 
> Gerd recently sent a slightly different patch:
> https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg00649.html
> 
> >      if (hostfd && libusb_speed == 0) {
> >          /*
> >           * Workaround libusb bug: libusb_get_device_speed() does not
> >