qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libqtest: Rename qmp_assert_error_class() to qmp_expect_erro


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] libqtest: Rename qmp_assert_error_class() to qmp_expect_error_and_unref()
Date: Wed, 2 Sep 2020 14:18:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/2/20 2:00 PM, Thomas Huth wrote:
> On 02/09/2020 13.57, Markus Armbruster wrote:
>> qmp_assert_error_class() does more than just assert: it also unrefs
>> the @rsp argument.  Rename to qmp_assert_error_class() to reduce
>> confusion.
> 
> s/to qmp_assert_error_class()/to qmp_expect_error_and_unref()/
> 
> With that nit fixed (I can do it when picking up the patch):
> 
> Acked-by: Thomas Huth <thuth@redhat.com>
> 
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]