Re: [PATCH v1 7/8] target/mips: simplify gen_compute_imm_branch logic

[Richard Henderson]

On 9/3/20 4:21 AM, Alex Bennée wrote:
> One of the Travis builds was complaining about:
> 
>   qemu/include/tcg/tcg.h:437:12: error: ‘cond’ may be used uninitialized in 
> this function [-Werror=maybe-uninitialized]
>        return (TCGCond)(c ^ 1);
>   ../target/mips/translate.c:20031:13: note: ‘cond’ was declared here
>        TCGCond cond;
> 
> Rather than figure out exactly which one was causing the complaint I
> just defaulted to TCG_COND_ALWAYS and allowed that state to double up
> for the now defunct bcond_compute variable.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  target/mips/translate.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)

This looks like a good cleanup.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~