[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 03/12] tcg: Fixes dup_const link error
From: |
Richard Henderson |
Subject: |
Re: [PATCH v4 03/12] tcg: Fixes dup_const link error |
Date: |
Thu, 3 Sep 2020 10:20:41 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/3/20 1:31 AM, Yonggang Luo wrote:
> Rename function dup_const to dup_const_eval for avoid confliction with macro
> dup_const
>
> The link error on msys2
>
> Linking target qemu-system-alpha.exe
> C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
> libqemu-alpha-softmmu.fa.p/tcg_optimize.c.obj: in function `tcg_optimize':
> E:\CI-Cor-Ready\xemu\qemu-build/../qemu.org/tcg/optimize.c:1106: undefined
> reference to `dup_const'
> C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
> libqemu-alpha-softmmu.fa.p/tcg_tcg-op-vec.c.obj: in function
> `tcg_gen_dupi_vec':
> E:\CI-Cor-Ready\xemu\qemu-build/../qemu.org/tcg/tcg-op-vec.c:283: undefined
> reference to `dup_const'
> collect2.exe: error: ld returned 1 exit status
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> include/tcg/tcg.h | 6 +++---
> tcg/tcg-op-gvec.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
No, really, as I asked before: what symbol is present in tcg-op-gvec.c.obj
without this patch?
That you need this, to me says that you've got a broken compiler. This is
bog-standard C. There is nothing windows-specific about it.
r~
- [PATCH v4 00/12] Green the msys2 CI make, Yonggang Luo, 2020/09/03
- [PATCH v4 04/12] tests: handling signal on win32 properly, Yonggang Luo, 2020/09/03
- [PATCH v4 05/12] configure: Fix include and linkage issue on msys2, Yonggang Luo, 2020/09/03
- [PATCH v4 06/12] block: Fixes nfs on msys2/mingw, Yonggang Luo, 2020/09/03
- [PATCH v4 07/12] osdep: These function are only available on Non-Win32 system., Yonggang Luo, 2020/09/03
- [PATCH v4 09/12] stubs: qemu_notify_event have no need to stub, Yonggang Luo, 2020/09/03
- [PATCH v4 08/12] ci: fixes msys2 build by upgrading capstone to 4.0.2, Yonggang Luo, 2020/09/03
- [PATCH v4 10/12] meson: Fixes qapi tests., Yonggang Luo, 2020/09/03