[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] meson: fix qxl module build
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] meson: fix qxl module build |
|
Date: |
Fri, 4 Sep 2020 14:24:45 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 04/09/20 14:14, Gerd Hoffmann wrote:
> Hi,
>
>>>> - qxl_ss.add(when: 'CONFIG_QXL', if_true: files('qxl.c', 'qxl-logger.c',
>>>> 'qxl-render.c'))
>>>> + qxl_ss.add(files('qxl.c', 'qxl-logger.c', 'qxl-render.c'))
>
>> You have found why it's got that "when:". :)
>
>> - module_ss = module_ss.apply(config_host, strict: false)
>> + module_ss = module_ss.apply(config_all, strict: false)
>
> Ah. That nicely explains why the "when:" didn't work in the
> first place.
>
>> etc. This would work also for the CONFIG_VIRTIO_GPU changes.
>
> Yes, virtio-gpu modules are next on the list ;)
Great, feel free to pick the patch up, no need for attribution or anything.
Paolo