RE: [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup

[Zhang, Chen]

> -----Original Message-----
> From: Pan Nengyuan <pannengyuan@huawei.com>
> Sent: Friday, September 4, 2020 9:49 PM
> To: qemu-devel@nongnu.org
> Cc: Zhang, Chen <chen.zhang@intel.com>; jasowang@redhat.com;
> zhang.zhanghailiang@huawei.com; kuhn.chenqun@huawei.com; Pan
> Nengyuan <pannengyuan@huawei.com>
> Subject: [PATCH] net/filter-rewriter: destroy g_hash_table in
> colo_rewriter_cleanup
> 
> s->connection_track_table forgot to destroy in colo_rewriter_cleanup. Fix it.
> 
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>

Oh, Thanks Euler Robot~~
Reviewed-by: Zhang Chen <chen.zhang@intel.com>

Thanks
Zhang Chen

> ---
>  net/filter-rewriter.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c index
> 1aaad101b6..9ff366d44f 100644
> --- a/net/filter-rewriter.c
> +++ b/net/filter-rewriter.c
> @@ -376,6 +376,8 @@ static void colo_rewriter_cleanup(NetFilterState *nf)
>          filter_rewriter_flush(nf);
>          g_free(s->incoming_queue);
>      }
> +
> +    g_hash_table_destroy(s->connection_track_table);
>  }
> 
>  static void colo_rewriter_setup(NetFilterState *nf, Error **errp)
> --
> 2.18.2