[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 16/19] target/microblaze: Move mmu parameters to MicroBlaz
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 16/19] target/microblaze: Move mmu parameters to MicroBlazeCPUConfig |
Date: |
Sat, 5 Sep 2020 23:41:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/4/20 9:08 PM, Richard Henderson wrote:
> The final 4 fields in MicroBlazeMMU are configuration constants.
> Move them into MicroBlazeCPUConfig where they belong.
>
> Remove the leading "c_" from the member names, as that presumably
> implied "config", and that should not be explicit in the location.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/microblaze/cpu.h | 5 +++++
> target/microblaze/mmu.h | 7 +------
> target/microblaze/cpu.c | 9 +++++----
> target/microblaze/helper.c | 4 ++--
> target/microblaze/mmu.c | 30 +++++++++++++++++-------------
> 5 files changed, 30 insertions(+), 25 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v3 12/19] target/microblaze: Split out MicroBlazeCPUConfig, (continued)
- [PATCH v3 12/19] target/microblaze: Split out MicroBlazeCPUConfig, Richard Henderson, 2020/09/04
- [PATCH v3 13/19] target/microblaze: Reorg MicroBlazeCPUConfig to minimize holes, Richard Henderson, 2020/09/04
- [PATCH v3 14/19] target/microblaze: Move pvr regs to MicroBlazeCPUConfig, Richard Henderson, 2020/09/04
- [PATCH v3 15/19] target/microblaze: Treat pvr_regs as constant, Richard Henderson, 2020/09/04
- [PATCH v3 18/19] target/microblaze: Put MicroBlazeCPUConfig into DisasContext, Richard Henderson, 2020/09/04
- [PATCH v3 16/19] target/microblaze: Move mmu parameters to MicroBlazeCPUConfig, Richard Henderson, 2020/09/04
- Re: [PATCH v3 16/19] target/microblaze: Move mmu parameters to MicroBlazeCPUConfig,
Philippe Mathieu-Daudé <=
- [PATCH v3 17/19] target/microblaze: Fill in VMStateDescription for cpu, Richard Henderson, 2020/09/04
- [PATCH v3 19/19] configure: Do not set TARGET_ABI32 for microblaze, Richard Henderson, 2020/09/04
- Re: [PATCH v3 00/19] target/microblaze improvements, Edgar E. Iglesias, 2020/09/07