[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 00/19] target/microblaze improvements
From: |
Edgar E. Iglesias |
Subject: |
Re: [PATCH v3 00/19] target/microblaze improvements |
Date: |
Mon, 7 Sep 2020 11:20:43 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Sep 04, 2020 at 12:08:23PM -0700, Richard Henderson wrote:
> Version 3:
>
> * Splits out MicroBlazeCPUConfig, and moves some values
> out of CPUMBState (env) that are constant configuration
> parameters, or derived from configuration parameters.
>
> * Do not save configuration parameters with vmstate.
> * Pass around MicroBlazeCPUConfig in the translator.
> * Do not set TARGET_ABI32 in configure.
>
> Version 2:
>
> * Includes fixes for iflags that could cause lockups.
>
> It seems it was easier to do so with icount=7, which is what we
> do during the replay acceptance tests. This causes TBs to contain
> no more than 7 insns, and often less to make up for an incomplete
> count elsewhere. Which stressed the iflags bits around delay slots
> and imm in ways that pure single-step doesn't.
>
> * cpu vmstate is filled in
> * interrupt logging is tidied.
>
>
> r~
Looks good, none of the test issues were relatd. Thanks Richard!
On all the patches I had not previously reviewed:
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Tested-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Can you take the pull-req via your trees?
Cheers,
Edgar
- Re: [PATCH v3 13/19] target/microblaze: Reorg MicroBlazeCPUConfig to minimize holes, (continued)
- [PATCH v3 14/19] target/microblaze: Move pvr regs to MicroBlazeCPUConfig, Richard Henderson, 2020/09/04
- [PATCH v3 15/19] target/microblaze: Treat pvr_regs as constant, Richard Henderson, 2020/09/04
- [PATCH v3 18/19] target/microblaze: Put MicroBlazeCPUConfig into DisasContext, Richard Henderson, 2020/09/04
- [PATCH v3 16/19] target/microblaze: Move mmu parameters to MicroBlazeCPUConfig, Richard Henderson, 2020/09/04
- [PATCH v3 17/19] target/microblaze: Fill in VMStateDescription for cpu, Richard Henderson, 2020/09/04
- [PATCH v3 19/19] configure: Do not set TARGET_ABI32 for microblaze, Richard Henderson, 2020/09/04
- Re: [PATCH v3 00/19] target/microblaze improvements,
Edgar E. Iglesias <=