Re: [PULL 00/30] ppc-for-5.2 queue 20200904

[Thiago Jung Bauermann]

Cornelia Huck <cohuck@redhat.com> writes:

> On Mon, 7 Sep 2020 21:46:28 +0200
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
>> On 9/7/20 7:26 PM, Laurent Vivier wrote:
>>
>> > We can't add a "#ifdef CONFIG_USER_ONLY" in hw/core/cpu.c to set halted
>> > to 0 because it is in the common files, but we can do:
>> > 
>> > diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
>> > index 73d7d6007e8e..749cd548f0f3 100644
>> > --- a/target/s390x/cpu.c
>> > +++ b/target/s390x/cpu.c
>> > @@ -291,9 +291,9 @@ static void s390_cpu_initfn(Object *obj)
>> >      S390CPU *cpu = S390_CPU(obj);
>> > 
>> >      cpu_set_cpustate_pointers(cpu);
>> > -    cs->start_powered_off = true;
>> >      cs->exception_index = EXCP_HLT;
>> >  #if !defined(CONFIG_USER_ONLY)
>> > +    cs->start_powered_off = true;
>> >      object_property_add(obj, "crash-information", "GuestPanicInformation",
>> >                          s390_cpu_get_crash_info_qom, NULL, NULL, NULL);
>> >      cpu->env.tod_timer =  
>> 
>> This looks like the correct fix indeed :)
>> (Maybe worth adding a comment around).
>
> Agreed on both counts.
>
>> Thanks for investigating!
>
> And here as well :)

Thank you very much for investigating and fixing this problem, Laurent!

Sorry for not working on this issue. I was out on an extended weekend
and just came back.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center