[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/10] hw/i386: make explicit clearing of pch_rev_id
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 07/10] hw/i386: make explicit clearing of pch_rev_id |
Date: |
Wed, 9 Sep 2020 14:58:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/9/20 1:27 PM, Alex Bennée wrote:
> Some compilers (notably the Xenial gcc in Travis) fail to spot that
> this will always be set if pch_dev_id != 0xffff. Given this is setup
> code and using _Pragma to override is equally as ugly lets just remove
> the doubt from the compilers mind.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> hw/i386/pc_piix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 32b1453e6a8..33fa035fb7f 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -930,7 +930,7 @@ void igd_passthrough_isa_bridge_create(PCIBus *bus,
> uint16_t gpu_dev_id)
> struct PCIDevice *bridge_dev;
> int i, num;
> uint16_t pch_dev_id = 0xffff;
> - uint8_t pch_rev_id;
> + uint8_t pch_rev_id = 0;
>
> num = ARRAY_SIZE(igd_combo_id_infos);
> for (i = 0; i < num; i++) {
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v2 01/10] CODING_STYLE.rst: flesh out our naming conventions., (continued)
- [PATCH v2 01/10] CODING_STYLE.rst: flesh out our naming conventions., Alex Bennée, 2020/09/09
- [PATCH v2 02/10] usb-host: restrict workaround to new libusb versions, Alex Bennée, 2020/09/09
- [PATCH v2 03/10] tests/meson.build: fp tests don't need CONFIG_TCG, Alex Bennée, 2020/09/09
- [PATCH v2 04/10] target/mips: simplify gen_compute_imm_branch logic, Alex Bennée, 2020/09/09
- [PATCH v2 06/10] configure: don't enable ppc64abi32-linux-user by default, Alex Bennée, 2020/09/09
- [PATCH v2 08/10] tests: bump avocado version, Alex Bennée, 2020/09/09
- [PATCH v2 07/10] hw/i386: make explicit clearing of pch_rev_id, Alex Bennée, 2020/09/09
- Re: [PATCH v2 07/10] hw/i386: make explicit clearing of pch_rev_id,
Philippe Mathieu-Daudé <=
- [PATCH v2 05/10] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation, Alex Bennée, 2020/09/09
- [PATCH v2 10/10] plugins: move the more involved plugins to contrib, Alex Bennée, 2020/09/09
- [PATCH v2 09/10] tests/acceptance: Add Test.fetch_asset(cancel_on_missing=True), Alex Bennée, 2020/09/09