qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 03/10] tests/meson.build: fp tests don't need CONFIG_TCG


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 03/10] tests/meson.build: fp tests don't need CONFIG_TCG
Date: Wed, 9 Sep 2020 15:03:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/9/20 1:27 PM, Alex Bennée wrote:
> As the tests build only softfloat.c no actual TCG machinary is neede

Typo "needed".

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> to test them (as is evidenced by GCC check-softfloat). Might as well
> fix the wording on Travis while at it.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20200903112107.27367-7-alex.bennee@linaro.org>
> ---
>  .travis.yml       | 2 +-
>  tests/meson.build | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 1d0ade0a133..65341634d02 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -138,7 +138,7 @@ jobs:
>  
>  
>      # Just build tools and run minimal unit and softfloat checks
> -    - name: "GCC check-softfloat (user)"
> +    - name: "GCC check-unit and check-softfloat"
>        env:
>          - BASE_CONFIG="--enable-tools"
>          - CONFIG="--disable-user --disable-system"
> diff --git a/tests/meson.build b/tests/meson.build
> index 998e4c48f90..dae8a77df14 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -259,8 +259,9 @@ test('decodetree', sh,
>       workdir: meson.current_source_dir() / 'decode',
>       suite: 'decodetree')
>  
> +subdir('fp')
> +
>  if 'CONFIG_TCG' in config_host
> -  subdir('fp')
>    if 'CONFIG_PLUGIN' in config_host
>      subdir('plugin')
>    endif
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]