[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Wind
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows |
|
Date: |
Sun, 13 Sep 2020 17:35:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/13/20 12:44 AM, Yonggang Luo wrote:
> On windows, a difference in line endings causes testsuite failures
> complaining that every single line in files such as
> 'tests/qapi-schemadoc-good.texi' is wrong. Fix it by adding -b to diff.
Isn't '--strip-trailing-cr' more adapted?
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/qapi-schema/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qapi-schema/meson.build b/tests/qapi-schema/meson.build
> index c87d141417..f1449298b0 100644
> --- a/tests/qapi-schema/meson.build
> +++ b/tests/qapi-schema/meson.build
> @@ -220,6 +220,6 @@ qapi_doc = custom_target('QAPI doc',
>
> # "full_path()" needed here to work around
> # https://github.com/mesonbuild/meson/issues/7585
> -test('QAPI doc', diff, args: ['-u', files('doc-good.texi'),
> qapi_doc[0].full_path()],
> +test('QAPI doc', diff, args: ['-b', '-u', files('doc-good.texi'),
> qapi_doc[0].full_path()],
> depends: qapi_doc,
> suite: ['qapi-schema', 'qapi-doc'])
>
- Re: [PATCH v8 02/27] block: Fixes nfs compiling error on msys2/mingw, (continued)
[PATCH v8 03/27] ci: fixes msys2 build by upgrading capstone to 4.0.2, Yonggang Luo, 2020/09/12
[PATCH v8 04/27] configure: Fixes ncursesw detection under msys2/mingw and enable curses, Yonggang Luo, 2020/09/12
[PATCH v8 05/27] win32: Simplify gmtime_r detection direct base on _POSIX_THREAD_SAFE_FUNCTIONS., Yonggang Luo, 2020/09/12
[PATCH v8 06/27] curses: Fixes curses compiling errors., Yonggang Luo, 2020/09/12
[PATCH v8 07/27] tests: disable /char/stdio/* tests in test-char.c on win32, Yonggang Luo, 2020/09/12
[PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows, Yonggang Luo, 2020/09/12
- Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows,
Philippe Mathieu-Daudé <=
Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows, Eric Blake, 2020/09/14
[PATCH v8 10/27] osdep: file locking functions are not available on Win32, Yonggang Luo, 2020/09/12
[PATCH v8 09/27] tests: test-replication disable /replication/secondary/* on msys2/mingw., Yonggang Luo, 2020/09/12
[PATCH v8 08/27] tests: Fixes test-replication.c on msys2/mingw., Yonggang Luo, 2020/09/12