qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 03/27] ci: fixes msys2 build by upgrading capstone to 4.0.


From: Yonggang Luo
Subject: Re: [PATCH v8 03/27] ci: fixes msys2 build by upgrading capstone to 4.0.2
Date: Mon, 14 Sep 2020 15:15:56 +0800



On Mon, Sep 14, 2020 at 3:10 PM Thomas Huth <thuth@redhat.com> wrote:
>
> On 13/09/2020 00.44, Yonggang Luo wrote:
> > The currently random version capstone have the following compiling issue:
> >   CC      /c/work/xemu/qemu/build/slirp/src/arp_table.o
> > make[1]: *** No rule to make target “/c/work/xemu/qemu/build/capstone/capstone.lib”。 Stop.
> >
> > Subproject commit 1d230532840a37ac032c6ab80128238fc930c6c1 are the tagged version 4.0.2
> > when upgrading to this version, the folder structure of include are changed to
> > qemu\capstone\include
> > │  platform.h
> > │
> > ├─capstone
> > │      arm.h
> > │      arm64.h
> > │      capstone.h
> > │      evm.h
> > │      m680x.h
> > │      m68k.h
> > │      mips.h
> > │      platform.h
> > │      ppc.h
> > │      sparc.h
> > │      systemz.h
> > │      tms320c64x.h
> > │      x86.h
> > │      xcore.h
> > │
> > └─windowsce
> >         intrin.h
> >         stdint.h
> >
> > in capstone. so we need add extra include path -I${source_path}/capstone/include/capstone
> > for directly #include <capstone.h>, and the exist include path should preserve, because
> > in capstone code there something like #include "capstone/capstone.h"
> >
> > If only using
> >     capstone_cflags="-I${source_path}/capstone/include/capstone"
> > Then will cause the following compiling error:
> >
> >   CC      cs.o
> > cs.c:17:10: fatal error: 'capstone/capstone.h' file not found
> > #include <capstone/capstone.h>
> >          ^~~~~~~~~~~~~~~~~~~~~
> > 1 error generated.
> >
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> > ---
> >  capstone  | 2 +-
> >  configure | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/capstone b/capstone
> > index 22ead3e0bf..1d23053284 160000
> > --- a/capstone
> > +++ b/capstone
> > @@ -1 +1 @@
> > -Subproject commit 22ead3e0bfdb87516656453336160e0a37b066bf
> > +Subproject commit 1d230532840a37ac032c6ab80128238fc930c6c1
>
> Richard has a patch series on the list now to update and improve the
> capstone submodule (see "capstone + disassembler patches") ... I think
> this patch here will then not be required anymore.
I've seen that, of cause, this patch need to be dropped.
>
>  Thomas
>


--
         此致

罗勇刚
Yours
    sincerely,
Yonggang Luo

reply via email to

[Prev in Thread] Current Thread [Next in Thread]